Skip to content

uefi: bump to 6.17#8716

Merged
igorpecovnik merged 7 commits intoarmbian:mainfrom
rpardini:pr/uefi-bump-to-617
Oct 6, 2025
Merged

uefi: bump to 6.17#8716
igorpecovnik merged 7 commits intoarmbian:mainfrom
rpardini:pr/uefi-bump-to-617

Conversation

@rpardini
Copy link
Member

@rpardini rpardini commented Oct 5, 2025

uefi: bump to 6.17

  • uefi-arm64-6.16: rewrite patches against 6.16 final, no changes
  • uefi: bump to 6.17
  • uefi-arm64: bump 6.16 -> 6.17 via rename
  • uefi-loong64-edge: bump to 6.17 via rename
  • uefi-arm64-6.17: rebase against v6.17
  • drivers_network: disable 6.17+ for rtl8811_rtl8812_rtl8814_rtl8821, rtl8811CU_rtl8821C and rtl88x2bu
    • two of those were already marked to be removed 6.12+
    • for those in need: send fix upstream, wait for merge, update here and re-enable
    • in case upstream abandoned: fork and fix, update here and re-enable
  • enable Realtek rtw88 USB adapters (8811/8821, 8812AU, 8814AU, 8822BU) @igorpecovnik

rpardini and others added 6 commits October 5, 2025 20:54
… `rtl8811CU_rtl8821C` and `rtl88x2bu`

- two of those were already marked to be removed 6.12+
- for those in need: send fix upstream, wait for merge, update here and re-enable
- in case upstream abandoned: fork and fix, update here and re-enable
@github-actions github-actions bot added 11 Milestone: Fourth quarter release size/small PR with less then 50 lines Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Framework Framework components Patches Patches related to kernel, U-Boot, ... labels Oct 5, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 5, 2025

Walkthrough

Updated EDGE kernel default from 6.16 to 6.17 (KERNEL_MAJOR_MINOR in config/sources/families/include/uefi_common.inc). Modified lib/functions/compilation/patch/drivers_network.sh to add upper-bound kernel checks (lt 6.17) to multiple Realtek/RTW driver conditional blocks (disabling those patches for kernel ≥6.17) and added inline comments; performed minor whitespace/alignment tweaks. Numerous linux-uefi-*.config fragments were edited to add/remove many CONFIG_ symbols across netfilter, audio, DRM, IOMMU, regulators, and wireless driver selections.

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

Suggested labels

Ready to merge, Build, size/small

Suggested reviewers

  • clee
  • joekhoobyar
  • krachlatte
  • igorpecovnik
  • amazingfate
  • pyavitz

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The pull request title “uefi: bump to 6.17” succinctly and accurately summarizes the core change of upgrading UEFI components to kernel version 6.17, which aligns directly with the updates in the diff.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
Description Check ✅ Passed The pull request description directly references bumping UEFI to version 6.17 and details the specific file renames, patch rewrites, driver disables, and Realtek adapter enablement that correspond to the changes in the diff. It is clearly on-topic and aligns with the code modifications.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@rpardini
Copy link
Member Author

rpardini commented Oct 5, 2025

This takes commit from #8685 (comment) for loong64

@rpardini rpardini marked this pull request as ready for review October 5, 2025 18:57
@rpardini rpardini requested review from a team and igorpecovnik as code owners October 5, 2025 18:57
@github-actions github-actions bot added the Ready to merge Reviewed, tested and ready for merge label Oct 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot removed the Needs review Seeking for review label Oct 6, 2025
@igorpecovnik
Copy link
Member

drivers_network: disable 6.17+ for rtl8811_rtl8812_rtl8814_rtl8821, rtl8811CU_rtl8821C and rtl88x2bu

Perhaps enabling their upstream substitutes in the config if not already?

… on UEFI edge kernels

And execute kernel config rewrite.
@github-actions github-actions bot added size/large PR with 250 lines or more and removed size/small PR with less then 50 lines labels Oct 6, 2025
@github-actions github-actions bot added Needs review Seeking for review and removed Ready to merge Reviewed, tested and ready for merge labels Oct 6, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2025

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot added Ready to merge Reviewed, tested and ready for merge and removed Needs review Seeking for review labels Oct 6, 2025
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
config/kernel/linux-uefi-loong64-edge.config (1)

2481-2481: Fix LSM typos in loong64 UEFI configs

  • config/kernel/linux-uefi-loong64-edge.config (line 2481): replace CONFIG_LSM="lalockdown,yama,integrity,apparmor" with CONFIG_LSM="landlock,lockdown,yama,integrity,apparmor".
  • config/kernel/linux-uefi-loong64-current.config (line 2506): replace CONFIG_LSM="landlockdown,yama,integrity,apparmor" with CONFIG_LSM="landlock,lockdown,yama,integrity,apparmor".
🧹 Nitpick comments (2)
config/kernel/linux-uefi-arm64-edge.config (2)

4025-4029: SOF stack enablement — confirm necessity on this flavor

SOF core and buses were enabled. If no platforms target SOF here, consider deferring to reduce image size; otherwise looks fine.


2939-2939: Align LOCHNAGAR MFD built-in with its consumers?

MFD_LOCHNAGAR=y while related users (clk/regulator/ASoC) are =m. This works, but consider making MFD_LOCHNAGAR=m for consistency unless early-boot usage is required.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1953af7 and 06d0047.

📒 Files selected for processing (4)
  • config/kernel/linux-uefi-arm64-edge.config (15 hunks)
  • config/kernel/linux-uefi-loong64-edge.config (7 hunks)
  • config/kernel/linux-uefi-riscv64-edge.config (10 hunks)
  • config/kernel/linux-uefi-x86-edge.config (13 hunks)
🧰 Additional context used
🧠 Learnings (4)
📚 Learning: 2025-07-27T15:54:35.119Z
Learnt from: pyavitz
PR: armbian/build#8421
File: config/kernel/linux-sunxi64-edge.config:2168-2173
Timestamp: 2025-07-27T15:54:35.119Z
Learning: In the Armbian build system, staging 802.11 drivers like CONFIG_RTLLIB, CONFIG_RTL8192E, CONFIG_R8712U are kept enabled alongside upstream rtw88 drivers because rtw88 is still under development and suffers from reliability issues. The staging drivers serve as necessary fallbacks when upstream drivers are unstable, prioritizing working hardware over avoiding technical conflicts.

Applied to files:

  • config/kernel/linux-uefi-loong64-edge.config
  • config/kernel/linux-uefi-x86-edge.config
📚 Learning: 2025-07-26T11:14:41.697Z
Learnt from: pyavitz
PR: armbian/build#8421
File: config/kernel/linux-sunxi64-edge.config:82-83
Timestamp: 2025-07-26T11:14:41.697Z
Learning: In Linux kernel 6.13 and later, CONFIG_ZBUD was deprecated and is scheduled for removal in kernel 6.15. The zbud compressed page allocator was found to consume more memory than alternatives like zsmalloc. Therefore, CONFIG_ZSWAP_ZPOOL_DEFAULT_ZBUD becomes obsolete in current kernels, and make defconfig will auto-correct by removing such deprecated options. This demonstrates how kernel defconfigs can be backwards compatible but not forward compatible.

Applied to files:

  • config/kernel/linux-uefi-riscv64-edge.config
  • config/kernel/linux-uefi-arm64-edge.config
📚 Learning: 2025-09-14T06:19:06.828Z
Learnt from: amazingfate
PR: armbian/build#8619
File: config/kernel/linux-rockchip-vendor.config:0-0
Timestamp: 2025-09-14T06:19:06.828Z
Learning: CONFIG_ZSWAP has an implicit kernel-level dependency on CONFIG_SWAP, so when CONFIG_ZSWAP=y is set in Armbian overlay configs, CONFIG_SWAP gets automatically enabled during kernel build configuration processing, even if not explicitly specified in the overlay file.

Applied to files:

  • config/kernel/linux-uefi-riscv64-edge.config
  • config/kernel/linux-uefi-arm64-edge.config
📚 Learning: 2025-07-22T07:02:58.863Z
Learnt from: igorpecovnik
PR: armbian/build#8408
File: lib/functions/compilation/patch/drivers_network.sh:258-260
Timestamp: 2025-07-22T07:02:58.863Z
Learning: In the Armbian build system, RTL8811CU/RTL8821C wireless driver deprecation starting with kernel 6.12+ is not due to build failures but because support is being integrated into the upstream RTW88 driver. The deprecated drivers still build and function correctly during the transition period.

Applied to files:

  • config/kernel/linux-uefi-riscv64-edge.config
  • config/kernel/linux-uefi-arm64-edge.config
🔇 Additional comments (26)
config/kernel/linux-uefi-riscv64-edge.config (5)

161-161: Netfilter/NFT expansions look good

Adds NETLINK_HOOK, GLUE_CT, NFT_CONNLIMIT/OSF and xt NAT targets. Matches edge-wide policy and improves nftables parity.

Also applies to: 179-179, 186-186, 201-201, 217-217, 219-219, 225-231, 271-271


1257-1258: RTW88 USB variants: confirm symbol availability and firmware

Enabling RTW88 *_AU modules is aligned with dropping OOT Realtek. Please confirm these Kconfig symbols exist in v6.17 and that linux-firmware for these chips is present in your images to avoid runtime probe failures.


2035-2048: SND_HDA settings on RISC-V: double-check intent

PREALLOC_SIZE=4096, HDA Intel and codec modules enabled. Likely harmless as modules, but RISC-V boards rarely ship HDA. Confirm this is intentional for generic UEFI/QEMU coverage.


2659-2660: RTC PCF85063 enablement

Good addition; lightweight and commonly used.


3055-3055: HARDENED_USERCOPY enabled

Security hardening retained. LGTM.

config/kernel/linux-uefi-x86-edge.config (9)

353-365: Netfilter additions for NAT and protocol matches

XT_TARGET_HL/NAT/NETMAP/REDIRECT/MASQUERADE and DCCP/SCTP matches added. Consistent with edge configs.

Also applies to: 381-381, 405-405


1765-1767: Enable RTW88 USB variants (8821AU/8812AU/8814AU)

Good replacement path for disabled OOT drivers in ≥6.17. Matches PR objectives.


3461-3461: DRM_SIMPLEDRM=y

Sensible for early display with UEFI; pairs well with i915/xe, etc.


3613-3613: FIRMWARE_EDID=y

Reasonable with SIMPLEDRM; improves fallback EDID handling.


3712-3733: SND_HDA power-save defaults and SCODEC additions

Tighter defaults and broader codec/amp coverage. Looks good.


2855-2856: MFD CS40L50 (I2C/SPI)

Fine to expose haptics/amp parts; no conflicts seen.


4669-4669: RTC PCF85063

Good to include.


5300-5313: TI ADC drivers: additions

Adds ADS1119/124S08/131E08 and ADC12138. Useful coverage; no concerns.


5080-5087: Laptop vendor drivers (Lenovo/ThinkPad family)

Reasonable enablement for broad x86 laptop support.

config/kernel/linux-uefi-loong64-edge.config (4)

176-176: Netfilter/NFT expansions

Same set as other edge arches; consistent and fine.

Also applies to: 236-236, 242-248, 264-264, 288-288


1153-1155: RTW88 USB variants (8821AU/8812AU/8814AU)

Matches strategy to replace OOT Realtek with upstream rtw88 for ≥6.17.


1698-1713: SND_HDA defaults and codec set

Power-save default and codec list look good for generic UEFI.


2122-2122: TI_ADC12138 enabled

OK; small, low-risk ADC driver.

config/kernel/linux-uefi-arm64-edge.config (8)

267-267: Netfilter surface expansion looks good

Enabling NETFILTER_NETLINK_HOOK plus HL/NAT/NETMAP/REDIRECT/MASQUERADE targets and DCCP/SCTP matches aligns with the 6.17 bump and keeps iptables compat available. No issues spotted.

Also applies to: 327-339, 355-355, 379-379


3894-3911: HDA enablement on arm64 UEFI — confirm intent/footprint

Adding HDA (controller + codecs + Tegra) increases build footprint; fine if desired for generic UEFI images. Please confirm this is intentional for edge ARM64.


5336-5338: IOMMUs for Rockchip/Sun50i

Building in ROCKCHIP_IOMMU and SUN50I_IOMMU is appropriate given ARCH_* selections. LGTM.


3445-3445: Rockchip VDEC enablement

CONFIG_VIDEO_ROCKCHIP_VDEC=m is a sensible add for wider SoC media support. LGTM.


4851-4851: Peripheral adds (RTC/ADC/PWM) — no issues

New RTC/ADC/PWM symbols as modules look harmless and broaden HW coverage. LGTM.

Also applies to: 5532-5532, 5536-5537, 5815-5815


6261-6263: Security hardening flags

FORTIFY_SOURCE and HARDENED_USERCOPY enabled — good defaults for edge. LGTM.


1756-1756: CONFIG_RTW88_8814AU availability confirmed in Linux v6.17 Verified that this Kconfig symbol is present in the v6.17 rtw88 Kconfig; no changes needed.


3643-3643: CONFIG_DRM_I2C_TDA998X presence confirmed in v6.17 Option remains defined in drivers/gpu/drm/bridge/Kconfig and builds as a module; no changes required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

11 Milestone: Fourth quarter release Framework Framework components Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more

Development

Successfully merging this pull request may close these issues.

3 participants