Skip to content

Update rtl88x2cs driver commit hash for kernel 6.17+#8735

Merged
adeepn merged 1 commit intoarmbian:mainfrom
jethome-iot:update_rtl88x2cs_driver_hash
Oct 9, 2025
Merged

Update rtl88x2cs driver commit hash for kernel 6.17+#8735
adeepn merged 1 commit intoarmbian:mainfrom
jethome-iot:update_rtl88x2cs_driver_hash

Conversation

@adeepn
Copy link
Member

@adeepn adeepn commented Oct 9, 2025

Description

Update rtl88x2cs driver commit hash for kernel 6.17+

GitHub issue reference: #8717

Signed-off-by: Viacheslav Bocharov <adeep@lexina.in>
@adeepn adeepn requested a review from a team as a code owner October 9, 2025 10:50
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 9, 2025

Walkthrough

Updates lib/functions/compilation/patch/drivers_network.sh by changing the commit hash used in driver_rtl88x2cs() for the Realtek 88x2cs wireless driver from 0ef9ddd619d2a386df90fd7c32b65958b0d675ed to 79884dd23267e6e9ec29546476d8f68a1442d180. The adjacent date comment is updated to Oct 09, 2025. No other logic or files are modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

Ready to merge, size/small, Framework, Patches

Suggested reviewers

  • rpardini
  • igorpecovnik
  • clee
  • pyavitz
  • krachlatte

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. You can run @coderabbitai generate docstrings to improve docstring coverage.
✅ Passed checks (2 passed)
Check name Status Explanation
Title Check ✅ Passed The title succinctly and accurately describes the primary change of updating the rtl88x2cs driver commit hash to support kernel 6.17 and newer, avoiding unnecessary detail while remaining clear to readers.
Description Check ✅ Passed The description directly states the update of the rtl88x2cs driver commit hash for kernel 6.17+ and references the related issue, making it clearly relevant to the pull request changes.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a6f0159 and c7188db.

📒 Files selected for processing (1)
  • lib/functions/compilation/patch/drivers_network.sh (1 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: amazingfate
PR: armbian/build#8595
File: lib/functions/compilation/patch/drivers_network.sh:0-0
Timestamp: 2025-09-09T07:30:22.419Z
Learning: RTW_WARN_LMT sed workaround in driver_rtl8852bs() function in lib/functions/compilation/patch/drivers_network.sh is necessary for kernel 6.1 compatibility, even when the upstream wifi-rtl8852bs driver has the macro defined for newer kernels. The workaround ensures cross-kernel compatibility from 6.1 to 6.16+.
📚 Learning: 2025-09-09T07:30:22.419Z
Learnt from: amazingfate
PR: armbian/build#8595
File: lib/functions/compilation/patch/drivers_network.sh:0-0
Timestamp: 2025-09-09T07:30:22.419Z
Learning: RTW_WARN_LMT sed workaround in driver_rtl8852bs() function in lib/functions/compilation/patch/drivers_network.sh is necessary for kernel 6.1 compatibility, even when the upstream wifi-rtl8852bs driver has the macro defined for newer kernels. The workaround ensures cross-kernel compatibility from 6.1 to 6.16+.

Applied to files:

  • lib/functions/compilation/patch/drivers_network.sh

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions github-actions bot added Needs review Seeking for review Framework Framework components size/small PR with less then 50 lines labels Oct 9, 2025
@github-actions github-actions bot added the 11 Milestone: Fourth quarter release label Oct 9, 2025
Copy link
Member

@EvilOlaf EvilOlaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assuming tested

@github-actions github-actions bot added the Ready to merge Reviewed, tested and ready for merge label Oct 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2025

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot removed the Needs review Seeking for review label Oct 9, 2025
@adeepn adeepn merged commit 8325404 into armbian:main Oct 9, 2025
1 check passed
@adeepn adeepn deleted the update_rtl88x2cs_driver_hash branch October 9, 2025 14:39
@rpardini rpardini mentioned this pull request Oct 9, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

11 Milestone: Fourth quarter release Framework Framework components Ready to merge Reviewed, tested and ready for merge size/small PR with less then 50 lines

Development

Successfully merging this pull request may close these issues.

2 participants