Initial support for Mekotronics R58-4X4

[igorpecovnik]

Description

Device tree was merged here armbian/linux-rockchip#403

How Has This Been Tested?

• @150balbes

Checklist:

• My code follows the style guidelines of this project
• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• My changes generate no new warnings
• Any dependent changes have been merged and published in downstream modules

[coderabbitai]

Walkthrough

Adds a new board configuration file at config/boards/mekotronics-r58-4x4.conf for the Mekotronics R58-4x4. The file declares board identifiers and build parameters: BOARD_NAME, BOARDFAMILY, BOARD_MAINTAINER, KERNEL_TARGET, BOOTCONFIG, BOOT_FDT_FILE, UEFI_EDK2_BOARD_ID, DISPLAY_MANAGER, and ASOUND_STATE. It also sources the vendor-specific settings from ${SRC}/config/sources/vendors/mekotronics/mekotronics-rk3588.conf.sh to integrate rk3588 vendor configuration.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• Mekotronics R58HD - add initial support #8494 — Adds Mekotronics RK3588 support including the asound.state.rk3588hd referenced by ASOUND_STATE in this PR.

Suggested labels

Needs review, size/large, Hardware, BSP

Suggested reviewers

• clee
• catalinii
• prahal
• rpardini
• paolosabatino
• pyavitz
• krachlatte

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title clearly summarizes the primary change by indicating that initial support is being added for the Mekotronics R58-4X4 board, which matches the new board configuration file introduced in this changeset.
Description Check	✅ Passed	The description references the upstream device tree merge and includes testing and checklist items that align with adding support for the new board, so it is clearly related to the changeset.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch r58-4x4

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

config/boards/mekotronics-r58-4x4.conf (1)

7-7: Minor: inconsistent whitespace after string value.

Line 7 appears to use tab characters between the closing quote and the inline comment, while other lines use spaces. This is a minor formatting inconsistency.

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 09160da and ccb6354.

📒 Files selected for processing (1)

• config/boards/mekotronics-r58-4x4.conf (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📚 Learning: 2025-09-14T06:29:18.958Z

Learnt from: amazingfate
PR: armbian/build#8619
File: config/sources/families/rockchip.conf:64-70
Timestamp: 2025-09-14T06:29:18.958Z
Learning: In the Armbian build system, vendor branch configurations in family files are designed to be shared across multiple SoCs within the same family that use the same vendor kernel tree. For example, rk35xx and rockchip-rk3588 families both use identical vendor branch settings (same KERNELSOURCE, KERNELBRANCH, and KERNELPATCHDIR), demonstrating that vendor branches are intentionally generic rather than SoC-specific.

Applied to files:

• config/boards/mekotronics-r58-4x4.conf

📚 Learning: 2025-09-11T06:12:54.213Z

Learnt from: SuperKali
PR: armbian/build#8609
File: config/boards/nanopi-r76s.conf:5-5
Timestamp: 2025-09-11T06:12:54.213Z
Learning: In the Armbian build system, board family configuration files (like config/sources/families/rk35xx.conf) can inherit kernel branch definitions from common include files (like config/sources/families/include/rockchip64_common.inc). Even if a branch like "edge" is not defined directly in the family conf file, it may be available through the sourced include file.

Applied to files:

• config/boards/mekotronics-r58-4x4.conf

🔇 Additional comments (3)

config/boards/mekotronics-r58-4x4.conf (3)

1-13: Overall structure looks good.

The board configuration file follows the standard Armbian pattern for RK3588-based boards. The variable declarations are appropriate, and the sourcing of vendor-specific configuration is consistent with the architecture described in the learnings. The main items to verify are the existence of the referenced configuration files (u-boot defconfig, DTB, asound state, and vendor config).

Based on learnings.

---

13-13: Vendor-specific config source confirmed
config/sources/vendors/mekotronics/mekotronics-rk3588.conf.sh exists as expected; no changes needed.

---

6-10: All referenced config files are present. The u-boot defconfig and audio state file exist in the repo; the DTB (rockchip/rk3588-r58-4x4.dtb) is built from the upstream DTS.