Skip to content

SpacemiT: Update EDGE to linux-6.17.y#8784

Merged
pyavitz merged 1 commit intoarmbian:mainfrom
pyavitz:BPI-F3-025
Oct 20, 2025
Merged

SpacemiT: Update EDGE to linux-6.17.y#8784
pyavitz merged 1 commit intoarmbian:mainfrom
pyavitz:BPI-F3-025

Conversation

@pyavitz
Copy link
Collaborator

@pyavitz pyavitz commented Oct 20, 2025

Boot tested on the BananaPi BPI-F3
https://paste.armbian.com/qolotibusu.yaml

Signed-off-by: Patrick Yavitz <pyavitz@gmail.com>
@pyavitz pyavitz requested a review from igorpecovnik as a code owner October 20, 2025 13:06
@github-actions github-actions bot added 11 Milestone: Fourth quarter release size/large PR with 250 lines or more Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Oct 20, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 20, 2025

Walkthrough

This PR updates the Spacemit board family kernel configuration to target Linux kernel version 6.17 instead of 6.16. Two configuration variables are modified: KERNELBRANCH is updated from branch:linux-6.16.y to branch:linux-6.17.y, and KERNEL_MAJOR_MINOR is updated from 6.16 to 6.17. These changes affect only the edge kernel branch for the Spacemit family with no logic or control flow modifications.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • armbian/build#8717: Updates family configuration to bump the edge kernel from 6.16 to 6.17, modifying the same kernel version variables across different family configurations.
  • armbian/build#8481: Directly modifies the Spacemit family edge kernel variables to target linux-6.17, updating the same kernel branch introduced in a prior configuration.
  • armbian/build#8390: Performs the same type of kernel version bump by updating KERNELBRANCH and KERNEL_MAJOR_MINOR in a different family configuration file.

Suggested labels

Build, size/medium, BSP

Suggested reviewers

  • igorpecovnik
  • adeepn
  • brentr
  • EvilOlaf

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title "SpacemiT: Update EDGE to linux-6.17.y" directly and clearly describes the main change in the pull request. It identifies the target component (SpacemiT), specifies the action (Update), and indicates the key modification (updating EDGE branch to linux-6.17.y). The title is concise, specific, and directly aligned with the changeset which updates KERNELBRANCH and KERNEL_MAJOR_MINOR variables from 6.16 to 6.17 in the spacemit.conf file.
Description Check ✅ Passed The pull request description states "Boot tested on the BananaPi BPI-F3" with a reference link to test results. While brief, this description is directly related to the changeset as it provides validation that the kernel version update has been tested on actual hardware. The description is not vague or generic, nor is it unrelated or off-topic—it provides meaningful context about the testing performed for this kernel upgrade.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 596b6c6 and 9f88c0b.

⛔ Files ignored due to path filters (6)
  • patch/kernel/archive/spacemit-6.17/0000.patching_config.yaml is excluded by !patch/**
  • patch/kernel/archive/spacemit-6.17/001-rtl8852bs-Turn-off-DEBUG-and-remove-RTW_WARN_LM.patch is excluded by !patch/**
  • patch/kernel/archive/spacemit-6.17/002-Max-freq-limitation-1.8GHz.patch is excluded by !patch/**
  • patch/kernel/archive/spacemit-6.17/003-Add-spacemit-k1x-spi-support.patch is excluded by !patch/**
  • patch/kernel/archive/spacemit-6.17/004-SpacemiT-K1-X-Forward-port-6.6.y-DTSI.patch is excluded by !patch/**
  • patch/kernel/archive/spacemit-6.17/dt/k1-bananapi-f3.dts is excluded by !patch/**
📒 Files selected for processing (1)
  • config/sources/families/spacemit.conf (1 hunks)
🧰 Additional context used
🧠 Learnings (4)
📚 Learning: 2025-06-25T03:42:09.086Z
Learnt from: EvilOlaf
PR: armbian/build#8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:42:09.086Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, KERNELSOURCE is explicitly declared when using unofficial or 3rd party kernel repositories (like the "dev" branch using https://github.com/apritzel/linux), but can be omitted when using the standard mainline kernel (like the "edge" branch) since it will fall back to the default mainline source.

Applied to files:

  • config/sources/families/spacemit.conf
📚 Learning: 2025-09-11T06:12:54.213Z
Learnt from: SuperKali
PR: armbian/build#8609
File: config/boards/nanopi-r76s.conf:5-5
Timestamp: 2025-09-11T06:12:54.213Z
Learning: In the Armbian build system, board family configuration files (like config/sources/families/rk35xx.conf) can inherit kernel branch definitions from common include files (like config/sources/families/include/rockchip64_common.inc). Even if a branch like "edge" is not defined directly in the family conf file, it may be available through the sourced include file.

Applied to files:

  • config/sources/families/spacemit.conf
📚 Learning: 2025-10-13T02:26:18.249Z
Learnt from: tabrisnet
PR: armbian/build#8746
File: config/sources/families/filogic.conf:61-68
Timestamp: 2025-10-13T02:26:18.249Z
Learning: In the Armbian build system, the "edge" kernel branch is intended to be bleeding-edge and experimental. It does not require hardware testing or stability verification before merging, as it's expected to contain potentially unstable or untested code for early adopters and developers.

Applied to files:

  • config/sources/families/spacemit.conf
📚 Learning: 2025-06-25T03:40:52.109Z
Learnt from: EvilOlaf
PR: armbian/build#8330
File: config/sources/families/sun55iw3.conf:32-36
Timestamp: 2025-06-25T03:40:52.109Z
Learning: In Armbian build system configuration files like config/sources/families/*.conf, when KERNELSOURCE is not explicitly declared in a case branch, the system falls back to a default KERNELSOURCE value, so missing KERNELSOURCE declarations are not critical issues.

Applied to files:

  • config/sources/families/spacemit.conf
🔇 Additional comments (1)
config/sources/families/spacemit.conf (1)

39-45: Branch verification successful—no issues found.

The linux-6.17.y branch exists in the upstream repository. The version updates to both KERNELBRANCH and KERNEL_MAJOR_MINOR are consistent and correctly limited to the edge branch. Boot testing has been performed.

Warning

Review ran into problems

🔥 Problems

Errors were encountered while retrieving linked issues.

Errors (1)
  • F3-025: Request failed with status code 404

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai bot requested review from EvilOlaf, adeepn and brentr October 20, 2025 13:07
@github-actions github-actions bot added the Ready to merge Reviewed, tested and ready for merge label Oct 20, 2025
@github-actions
Copy link
Contributor

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot removed the Needs review Seeking for review label Oct 20, 2025
@pyavitz pyavitz merged commit 5decdbf into armbian:main Oct 20, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

11 Milestone: Fourth quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more

Development

Successfully merging this pull request may close these issues.

2 participants