Skip to content

rockchip: x3568 v4: sync changes from mainline and fixes phy leds#8887

Merged
igorpecovnik merged 2 commits intoarmbian:mainfrom
rbqvq:x3568v4
Nov 8, 2025
Merged

rockchip: x3568 v4: sync changes from mainline and fixes phy leds#8887
igorpecovnik merged 2 commits intoarmbian:mainfrom
rbqvq:x3568v4

Conversation

@rbqvq
Copy link
Member

@rbqvq rbqvq commented Nov 7, 2025 •
edited by coderabbitai bot
Loading

Description

  • DeviceTree merged into linux-rockchip@for-next (v6.19), sync final changes.
  • Enable netdev trigger by default for phy leds.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

UBoot upstreaming work will after Linux v6.19 released

Summary by CodeRabbit

  • New Features

    • Added support for the 9Tripod X3568 v4 board variant with extended RAM capacity (up to 16 GB).

  • Documentation

    • Updated board documentation and specifications to reflect support for multiple core board variations and the I/O board configuration.

rbqvq added 2 commits November 7, 2025 13:50
@rbqvq
rockchip: x3568 v4: sync changes from linux mainline
120a0fb 
9Tripod X3568 v4 are merged into linux mainline.

Sync these changes.
@rbqvq
rockchip: x3568 v4: enable netdev trigger by default for phy leds
22e73a8 
Enable netdev trigger by default that used for phy leds.
@github-actions github-actions bot added 11 Milestone: Fourth quarter release size/large PR with 250 lines or more Needs review Seeking for review Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... labels Nov 7, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 7, 2025 •
edited
Loading

Walkthrough

The PR modifies the 9Tripod X3568 v4 board configuration and kernel device tree definitions across two Rockchip kernel versions (6.12 and 6.18). Changes include adding a network LED trigger module to the board config, removing GMAC clock-in-out pin references and certain SD card ultra-high-speed modes from device trees, and completely removing camera and video demo device tree overlay files and their build references.

Changes

Cohort / File(s) Summary
Board Configuration
config/boards/9tripod-x3568-v4.csc		 Added MODULES="ledtrig_netdev" variable assignment
Kernel 6.12 Device Tree Core
patch/kernel/archive/rockchip64-6.12/dt/rk3568-9tripod-x3568-v4.dts		 Removed clkinout pins from gmac0 and gmac1 pinctrl-0 entries; removed three SDR modes (sd-uhs-sdr12, sd-uhs-sdr25, sd-uhs-sdr50) from sdmmc2; consolidated pmic_int pins formatting
Kernel 6.12 Overlays
patch/kernel/archive/rockchip64-6.12/overlay/Makefile, patch/kernel/archive/rockchip64-6.12/overlay/rk3568-9tripod-x3568-v4-camera-demo.dtso, patch/kernel/archive/rockchip64-6.12/overlay/rk3568-9tripod-x3568-v4-video-demo.dtso		 Removed two DTBO entries from Makefile; completely deleted camera-demo overlay (regulator, CSI D-PHY, I2C camera config); completely deleted video-demo overlay (backlight, regulators, DSI, touchscreen config)
Kernel 6.18 Device Tree Core
patch/kernel/archive/rockchip64-6.18/dt/rk3568-9tripod-x3568-v4.dts		 Removed gmac0_clkinout and gmac1m1_clkinout from pinctrl-0; removed disable-wp and three SDR modes from sdmmc2; reformatted pmic_int pins to single line
Kernel 6.18 Overlays
patch/kernel/archive/rockchip64-6.18/overlay/Makefile, patch/kernel/archive/rockchip64-6.18/overlay/rk3568-9tripod-x3568-v4-camera-demo.dtso, patch/kernel/archive/rockchip64-6.18/overlay/rk3568-9tripod-x3568-v4-video-demo.dtso		 Removed two DTBO entries from Makefile; completely deleted camera-demo overlay (regulator, pinctrl, CSI D-PHY, I2C camera config); completely deleted video-demo overlay (backlight, regulators, pinctrl, DSI host, touchscreen config)
U-Boot Patch Documentation
patch/u-boot/v2025.10/board_9tripod-x3568-v4/0001-arm-rockchip-Add-support-for-the-9Tripod-X3568-v4.patch		 Updated documentation to reference multiple core board variants (X3568CV2/CV3/CV4); expanded hardware differences section; widened RAM range to 2-16 GB; refined PCIe/USB/SD/MMC specifications; added gmac pinctrl adjustments and new U-Boot DT files; updated Makefile for kernel DTS installation

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

  • The changes follow a consistent pattern across two kernel versions (6.12 and 6.18), reducing cognitive load
  • Device tree modifications are straightforward (removing specific pin references and SD modes)
  • Overlay deletions are cleancut removals without migration complexity
  • Multiple files affected but homogeneous changes throughout

Possibly related PRs

Suggested labels

Ready to merge

Suggested reviewers

  • prahal
  • rpardini
  • krachlatte
  • paolosabatino
  • igorpecovnik
  • pyavitz
  • clee

Poem

🐰 Cameras and videos fade away,
Clock-outs and SD modes don't stay,
Device trees pruned with gentle care,
The 9Tripod's config floats in air—
Ledtrig sparks ignite the night! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main changes: syncing kernel device tree changes from mainline and enabling the netdev trigger for PHY LEDs via the MODULES variable.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 1f315c7 and 22e73a8.

📒 Files selected for processing (10)
  • config/boards/9tripod-x3568-v4.csc (1 hunks)
  • patch/kernel/archive/rockchip64-6.12/dt/rk3568-9tripod-x3568-v4.dts (3 hunks)
  • patch/kernel/archive/rockchip64-6.12/overlay/Makefile (0 hunks)
  • patch/kernel/archive/rockchip64-6.12/overlay/rk3568-9tripod-x3568-v4-camera-demo.dtso (0 hunks)
  • patch/kernel/archive/rockchip64-6.12/overlay/rk3568-9tripod-x3568-v4-video-demo.dtso (0 hunks)
  • patch/kernel/archive/rockchip64-6.18/dt/rk3568-9tripod-x3568-v4.dts (3 hunks)
  • patch/kernel/archive/rockchip64-6.18/overlay/Makefile (0 hunks)
  • patch/kernel/archive/rockchip64-6.18/overlay/rk3568-9tripod-x3568-v4-camera-demo.dtso (0 hunks)
  • patch/kernel/archive/rockchip64-6.18/overlay/rk3568-9tripod-x3568-v4-video-demo.dtso (0 hunks)
  • patch/u-boot/v2025.10/board_9tripod-x3568-v4/0001-arm-rockchip-Add-support-for-the-9Tripod-X3568-v4.patch (7 hunks)
💤 Files with no reviewable changes (6)
  • patch/kernel/archive/rockchip64-6.12/overlay/rk3568-9tripod-x3568-v4-camera-demo.dtso
  • patch/kernel/archive/rockchip64-6.18/overlay/Makefile
  • patch/kernel/archive/rockchip64-6.18/overlay/rk3568-9tripod-x3568-v4-video-demo.dtso
  • patch/kernel/archive/rockchip64-6.12/overlay/Makefile
  • patch/kernel/archive/rockchip64-6.18/overlay/rk3568-9tripod-x3568-v4-camera-demo.dtso
  • patch/kernel/archive/rockchip64-6.12/overlay/rk3568-9tripod-x3568-v4-video-demo.dtso
🧰 Additional context used
🧠 Learnings (15)
📓 Common learnings 
Learnt from: EvilOlaf
Repo: armbian/build PR: 8428
File: config/boards/lckfb-taishanpi.csc:5-9
Timestamp: 2025-07-25T03:51:50.830Z
Learning: When reviewing PRs in the Armbian build system, U-Boot defconfig files and patches may be added as part of the PR changes but might not be visible in the current repository clone state during review. It's important to check the actual PR file changes directly via GitHub or the PR API to get the complete picture of what files are being added or modified.

Learnt from: tabrisnet
Repo: armbian/build PR: 8661
File: lib/functions/compilation/armbian-kernel.sh:194-199
Timestamp: 2025-09-25T18:37:00.330Z
Learning: In PR armbian/build#8661, line 235 of lib/functions/compilation/armbian-kernel.sh already contains the corrected comment "BPF link support for netfilter hooks" for NETFILTER_BPF_LINK, not the misleading "BPF_SYSCALL" comment that was flagged during review.

Learnt from: tabrisnet
Repo: armbian/build PR: 8661
File: lib/functions/compilation/armbian-kernel.sh:194-199
Timestamp: 2025-09-25T18:37:00.330Z
Learning: In PR armbian/build#8661, line 235 of lib/functions/compilation/armbian-kernel.sh already contains the corrected comment "BPF link support for netfilter hooks" for NETFILTER_BPF_LINK, not the misleading "BPF_SYSCALL" comment that was flagged during review.

Learnt from: EvilOlaf
Repo: armbian/build PR: 8428
File: config/boards/lckfb-taishanpi.csc:5-9
Timestamp: 2025-07-25T03:51:50.830Z
Learning: When reviewing PRs in the Armbian build system, U-Boot defconfig files and patches may be added as part of the PR changes but might not be visible in the current repository clone state during review. It's important to check the actual PR file changes directly via GitHub API (https://api.github.com/repos/armbian/build/pulls/{pr_number}/files) to get the complete picture of what files are being added or modified, especially for U-Boot patches that will be applied during the build process.

Learnt from: amazingfate
Repo: armbian/build PR: 8619
File: config/sources/families/rockchip.conf:222-230
Timestamp: 2025-09-14T06:32:29.806Z
Learning: In the Armbian build system, the write_uboot_platform() function implementations follow different patterns across Rockchip family files. The newer standard (used in rockchip64_common.inc and rk3506) includes 'status=none' parameter in dd commands, while older implementations (rk3288, rk322x) use an older pattern without this parameter. The rk3506 implementation correctly follows the current Rockchip family standard.

Learnt from: rpardini
Repo: armbian/build PR: 8044
File: patch/u-boot/v2025.04/cmd-fileenv-read-string-from-file-into-env.patch:76-86
Timestamp: 2025-03-31T22:20:48.475Z
Learning: For the Armbian build project, maintaining consistency with existing patches across U-Boot versions (such as between 2025.01 and 2025.04) is prioritized over refactoring individual patches for code improvements.

Learnt from: HackingGate
Repo: armbian/build PR: 8665
File: config/boards/photonicat2.csc:4-4
Timestamp: 2025-10-26T10:41:35.118Z
Learning: In the Armbian build system, rk3576 boards consistently use BOARDFAMILY="rk35xx" for both vendor and edge kernel targets. The rk35xx family configuration sources rockchip64_common.inc, which provides edge and current kernel branch definitions, making these branches available even though they're not defined directly in rk35xx.conf.

Learnt from: EvilOlaf
Repo: armbian/build PR: 8619
File: config/sources/families/rockchip.conf:64-70
Timestamp: 2025-09-14T06:10:25.610Z
Learning: In the Armbian build system, rk32xx and rk33xx Rockchip SoCs no longer have BSP-based (vendor) kernel branches. The rk3506 is the first 32-bit Rockchip SoC to use the vendor branch in the current codebase.

Learnt from: tabrisnet
Repo: armbian/build PR: 8746
File: config/kernel/linux-filogic-edge.config:344-470
Timestamp: 2025-10-11T19:52:54.648Z
Learning: The chainsx/linux-filogic kernel (legacy branch) for BPI-R4 uses out-of-tree proprietary drivers (CONFIG_NET_DSA_AN8855, CONFIG_AIROHA_EN8801SC_PHY, CONFIG_AIR_AN8855_PHY, CONFIG_MDIO_AN8855, CONFIG_MFD_AIROHA_AN8855). The frank-w/BPI-Router-Linux kernel (current and edge branches) uses mainline kernel drivers instead: CONFIG_NET_DSA_MT7530 for the DSA switch and CONFIG_MEDIATEK_2P5GE_PHY for PHY support. These provide equivalent functionality for BPI-R4 networking.

Learnt from: amazingfate
Repo: armbian/build PR: 8619
File: config/sources/families/rockchip.conf:64-70
Timestamp: 2025-09-14T06:29:18.958Z
Learning: In the Armbian build system, vendor branch configurations in family files are designed to be shared across multiple SoCs within the same family that use the same vendor kernel tree. For example, rk35xx and rockchip-rk3588 families both use identical vendor branch settings (same KERNELSOURCE, KERNELBRANCH, and KERNELPATCHDIR), demonstrating that vendor branches are intentionally generic rather than SoC-specific.

Learnt from: igorpecovnik
Repo: armbian/build PR: 8849
File: config/boards/radxa-e54c.csc:14-28
Timestamp: 2025-11-02T20:49:56.719Z
Learning: In Armbian board configuration files (config/boards/*.conf, *.csc, etc.), do not use kernel_config_set, kernel_config_set_m, kernel_config_set_y, or custom_kernel_config__* functions to modify kernel configuration. Kernel configuration is associated with LINUXFAMILY/BOARDFAMILY, not individual BOARD. Board-specific kernel modifications cause inconsistency in kernel packages published to the apt repository because boards within a family share the same kernel packages. Kernel configuration changes must be made in the appropriate kernel config file (e.g., config/kernel/linux-*-*.config) or in family configuration files (config/sources/families/*.conf, *.inc) instead.

Learnt from: igorpecovnik
Repo: armbian/build PR: 8789
File: config/kernel/linux-sunxi64-edge.config:839-839
Timestamp: 2025-10-22T07:51:53.015Z
Learning: In Armbian's wireless driver configuration, CONFIG_RK_WIFI_DEVICE_* options are Rockchip-specific device registration settings, while CONFIG_WLAN_UWE* are the actual cross-platform driver modules for UWE5622 wireless chips. The UWE5622 chip (manufactured by Unisoc/Spreadtrum) is used on multiple Allwinner boards including Orange Pi Zero 2/2W/3 and Orange Pi 3 LTS, so CONFIG_WLAN_UWE5621/5622 along with Unisoc infrastructure options (CONFIG_SPARD_WLAN_SUPPORT, CONFIG_SC23XX, CONFIG_UNISOC_WIFI_PS, CONFIG_WCN_BSP_DRIVER_BUILDIN) are correct in sunxi64 kernel configs.

Learnt from: EvilOlaf
Repo: armbian/build PR: 8328
File: lib/functions/compilation/patch/drivers_network.sh:542-545
Timestamp: 2025-06-24T10:08:40.313Z
Learning: In the Armbian build system, when a PR removes build support for a specific kernel version, version check issues for that removed version become practically irrelevant even if they appear incorrect in isolation. Context about which kernel versions are being deprecated/removed is important for understanding the impact of version-related code changes.

Learnt from: igorpecovnik
Repo: armbian/build PR: 8705
File: .github/workflows/rewrite-kernel-configs.yml:96-169
Timestamp: 2025-10-03T11:42:46.660Z
Learning: In the Armbian build repository's kernel config rewrite workflow (.github/workflows/rewrite-kernel-configs.yml), deletion of kernel config files does not need to be handled. The workflow intentionally only captures ACMR (added/copied/modified/renamed) changes and does not need to propagate deletions to the aggregator.
📚 Learning: 2025-09-07T17:39:32.272Z 
Learnt from: EvilOlaf
Repo: armbian/build PR: 8586
File: config/boards/nanopi-r76s.conf:15-21
Timestamp: 2025-09-07T17:39:32.272Z
Learning: In the Armbian build system, the variables $BOARD and $SDCARD are always set by the build framework, so guard checks for these variables are unnecessary in board configuration files and hook functions.

Applied to files:

  • config/boards/9tripod-x3568-v4.csc
📚 Learning: 2025-11-02T20:49:56.719Z 
Learnt from: igorpecovnik
Repo: armbian/build PR: 8849
File: config/boards/radxa-e54c.csc:14-28
Timestamp: 2025-11-02T20:49:56.719Z
Learning: In Armbian board configuration files (config/boards/*.conf, *.csc, etc.), do not use kernel_config_set, kernel_config_set_m, kernel_config_set_y, or custom_kernel_config__* functions to modify kernel configuration. Kernel configuration is associated with LINUXFAMILY/BOARDFAMILY, not individual BOARD. Board-specific kernel modifications cause inconsistency in kernel packages published to the apt repository because boards within a family share the same kernel packages. Kernel configuration changes must be made in the appropriate kernel config file (e.g., config/kernel/linux-*-*.config) or in family configuration files (config/sources/families/*.conf, *.inc) instead.

Applied to files:

  • config/boards/9tripod-x3568-v4.csc
📚 Learning: 2025-10-26T10:41:35.118Z 
Learnt from: HackingGate
Repo: armbian/build PR: 8665
File: config/boards/photonicat2.csc:4-4
Timestamp: 2025-10-26T10:41:35.118Z
Learning: In the Armbian build system, rk3576 boards consistently use BOARDFAMILY="rk35xx" for both vendor and edge kernel targets. The rk35xx family configuration sources rockchip64_common.inc, which provides edge and current kernel branch definitions, making these branches available even though they're not defined directly in rk35xx.conf.

Applied to files:

  • config/boards/9tripod-x3568-v4.csc
  • patch/u-boot/v2025.10/board_9tripod-x3568-v4/0001-arm-rockchip-Add-support-for-the-9Tripod-X3568-v4.patch
📚 Learning: 2025-09-12T21:44:09.061Z 
Learnt from: Grippy98
Repo: armbian/build PR: 8624
File: config/boards/sk-am62p.conf:8-8
Timestamp: 2025-09-12T21:44:09.061Z
Learning: For TI K3 family boards in Armbian, BOOT_FDT_FILE uses .dts extension (not .dtb) as the standard convention. The build system handles this correctly by automatically compiling .dts to .dtb during kernel build and using the BOOT_FDT_FILE value directly in bootloader configurations.

Applied to files:

  • config/boards/9tripod-x3568-v4.csc
📚 Learning: 2025-06-04T23:45:38.860Z 
Learnt from: djurny
Repo: armbian/build PR: 8272
File: config/bootscripts/boot-mvebu.cmd:182-186
Timestamp: 2025-06-04T23:45:38.860Z
Learning: In config/bootscripts/boot-mvebu.cmd, the `fdtfile` variable is mandatory for booting and is pre-set by U-Boot, but can be overridden via armbianEnv.txt. If `fdtfile` is empty, the subsequent device tree file search logic will eventually fail and trigger the critical error "Cannot find DT!" with proper error handling.

Applied to files:

  • config/boards/9tripod-x3568-v4.csc
📚 Learning: 2025-09-14T06:32:29.806Z 
Learnt from: amazingfate
Repo: armbian/build PR: 8619
File: config/sources/families/rockchip.conf:222-230
Timestamp: 2025-09-14T06:32:29.806Z
Learning: In the Armbian build system, the write_uboot_platform() function implementations follow different patterns across Rockchip family files. The newer standard (used in rockchip64_common.inc and rk3506) includes 'status=none' parameter in dd commands, while older implementations (rk3288, rk322x) use an older pattern without this parameter. The rk3506 implementation correctly follows the current Rockchip family standard.

Applied to files:

  • config/boards/9tripod-x3568-v4.csc
  • patch/kernel/archive/rockchip64-6.18/dt/rk3568-9tripod-x3568-v4.dts
  • patch/u-boot/v2025.10/board_9tripod-x3568-v4/0001-arm-rockchip-Add-support-for-the-9Tripod-X3568-v4.patch
  • patch/kernel/archive/rockchip64-6.12/dt/rk3568-9tripod-x3568-v4.dts
📚 Learning: 2025-07-23T07:30:52.265Z 
Learnt from: EvilOlaf
Repo: armbian/build PR: 8417
File: config/boards/orangepi5pro.csc:57-58
Timestamp: 2025-07-23T07:30:52.265Z
Learning: In the Armbian build system, BOOTPATCHDIR can contain board-specific subdirectories (e.g., board_orangepi5pro) for applying patches to specific boards only. The framework automatically checks if such board-specific subdirectories exist for the board being built and applies those patches accordingly.

Applied to files:

  • config/boards/9tripod-x3568-v4.csc
  • patch/u-boot/v2025.10/board_9tripod-x3568-v4/0001-arm-rockchip-Add-support-for-the-9Tripod-X3568-v4.patch
📚 Learning: 2025-10-22T07:51:53.015Z 
Learnt from: igorpecovnik
Repo: armbian/build PR: 8789
File: config/kernel/linux-sunxi64-edge.config:839-839
Timestamp: 2025-10-22T07:51:53.015Z
Learning: In Armbian's wireless driver configuration, CONFIG_RK_WIFI_DEVICE_* options are Rockchip-specific device registration settings, while CONFIG_WLAN_UWE* are the actual cross-platform driver modules for UWE5622 wireless chips. The UWE5622 chip (manufactured by Unisoc/Spreadtrum) is used on multiple Allwinner boards including Orange Pi Zero 2/2W/3 and Orange Pi 3 LTS, so CONFIG_WLAN_UWE5621/5622 along with Unisoc infrastructure options (CONFIG_SPARD_WLAN_SUPPORT, CONFIG_SC23XX, CONFIG_UNISOC_WIFI_PS, CONFIG_WCN_BSP_DRIVER_BUILDIN) are correct in sunxi64 kernel configs.

Applied to files:

  • patch/kernel/archive/rockchip64-6.18/dt/rk3568-9tripod-x3568-v4.dts
  • patch/u-boot/v2025.10/board_9tripod-x3568-v4/0001-arm-rockchip-Add-support-for-the-9Tripod-X3568-v4.patch
  • patch/kernel/archive/rockchip64-6.12/dt/rk3568-9tripod-x3568-v4.dts
📚 Learning: 2025-03-31T22:20:41.849Z 
Learnt from: rpardini
Repo: armbian/build PR: 8044
File: patch/u-boot/v2025.04/cmd-fileenv-read-string-from-file-into-env.patch:73-75
Timestamp: 2025-03-31T22:20:41.849Z
Learning: When porting patches between U-Boot versions (like from 2025.01 to 2025.04), rpardini prefers to maintain patches as-is rather than introducing refactoring changes, even when potential improvements are identified. This approach prioritizes consistency and reduces the risk of introducing new issues.

Applied to files:

  • patch/u-boot/v2025.10/board_9tripod-x3568-v4/0001-arm-rockchip-Add-support-for-the-9Tripod-X3568-v4.patch
📚 Learning: 2025-03-31T22:20:48.475Z 
Learnt from: rpardini
Repo: armbian/build PR: 8044
File: patch/u-boot/v2025.04/cmd-fileenv-read-string-from-file-into-env.patch:76-86
Timestamp: 2025-03-31T22:20:48.475Z
Learning: For the Armbian build project, maintaining consistency with existing patches across U-Boot versions (such as between 2025.01 and 2025.04) is prioritized over refactoring individual patches for code improvements.

Applied to files:

  • patch/u-boot/v2025.10/board_9tripod-x3568-v4/0001-arm-rockchip-Add-support-for-the-9Tripod-X3568-v4.patch
📚 Learning: 2025-07-25T03:51:50.830Z 
Learnt from: EvilOlaf
Repo: armbian/build PR: 8428
File: config/boards/lckfb-taishanpi.csc:5-9
Timestamp: 2025-07-25T03:51:50.830Z
Learning: When reviewing PRs in the Armbian build system, U-Boot defconfig files and patches may be added as part of the PR changes but might not be visible in the current repository clone state during review. It's important to check the actual PR file changes directly via GitHub or the PR API to get the complete picture of what files are being added or modified.

Applied to files:

  • patch/u-boot/v2025.10/board_9tripod-x3568-v4/0001-arm-rockchip-Add-support-for-the-9Tripod-X3568-v4.patch
📚 Learning: 2025-07-25T03:51:50.830Z 
Learnt from: EvilOlaf
Repo: armbian/build PR: 8428
File: config/boards/lckfb-taishanpi.csc:5-9
Timestamp: 2025-07-25T03:51:50.830Z
Learning: When reviewing PRs in the Armbian build system, U-Boot defconfig files and patches may be added as part of the PR changes but might not be visible in the current repository clone state during review. It's important to check the actual PR file changes directly via GitHub API (https://api.github.com/repos/armbian/build/pulls/{pr_number}/files) to get the complete picture of what files are being added or modified, especially for U-Boot patches that will be applied during the build process.

Applied to files:

  • patch/u-boot/v2025.10/board_9tripod-x3568-v4/0001-arm-rockchip-Add-support-for-the-9Tripod-X3568-v4.patch
📚 Learning: 2025-11-06T15:36:04.606Z 
Learnt from: rpardini
Repo: armbian/build PR: 8879
File: config/sources/families/uefi-x86.conf:0-0
Timestamp: 2025-11-06T15:36:04.606Z
Learning: As of PR #8879, the uefi-x86 family in the Armbian build system now includes kernel patches for the first time. The current and edge branches for uefi-x86 are specifically configured for Apple T2-based x86 machines, including T2-specific patches from the linux-t2 project and custom kernel configuration options for Apple hardware drivers.

Applied to files:

  • patch/u-boot/v2025.10/board_9tripod-x3568-v4/0001-arm-rockchip-Add-support-for-the-9Tripod-X3568-v4.patch
📚 Learning: 2025-09-14T06:10:25.610Z 
Learnt from: EvilOlaf
Repo: armbian/build PR: 8619
File: config/sources/families/rockchip.conf:64-70
Timestamp: 2025-09-14T06:10:25.610Z
Learning: In the Armbian build system, rk32xx and rk33xx Rockchip SoCs no longer have BSP-based (vendor) kernel branches. The rk3506 is the first 32-bit Rockchip SoC to use the vendor branch in the current codebase.

Applied to files:

  • patch/u-boot/v2025.10/board_9tripod-x3568-v4/0001-arm-rockchip-Add-support-for-the-9Tripod-X3568-v4.patch
🔇 Additional comments (10)
config/boards/9tripod-x3568-v4.csc (1)

12-12: LGTM! Module addition correctly enables PHY LED functionality.

The ledtrig_netdev module is required for the netdev LED triggers configured in post_family_tweaks_bsp__9tripod_x3568_v4_enable_leds (lines 44-87), which set up LED behavior for the board's Ethernet PHY LEDs.

patch/kernel/archive/rockchip64-6.12/dt/rk3568-9tripod-x3568-v4.dts (3)

275-279: LGTM! Mainline sync simplifies GMAC0 pinctrl configuration.

Removal of the clkinout pin reference and reformatting align with the mainline linux-rockchip changes being synced from for-next (v6.19).

291-295: LGTM! Mainline sync simplifies GMAC1 pinctrl configuration.

Consistent with gmac0 changes, this removes the clkinout pin reference and reformats the pinctrl list.

675-675: LGTM! Formatting consolidated to single line.

Minor formatting improvement with no functional change.

patch/kernel/archive/rockchip64-6.18/dt/rk3568-9tripod-x3568-v4.dts (2)

275-295: LGTM! Changes consistent with 6.12 kernel version.

The gmac0/gmac1 pinctrl simplifications are identical to those in the rockchip64-6.12 DT file, maintaining consistency across kernel versions while syncing with mainline changes.

675-675: LGTM! Formatting change consistent across kernel versions.

patch/u-boot/v2025.10/board_9tripod-x3568-v4/0001-arm-rockchip-Add-support-for-the-9Tripod-X3568-v4.patch (4)

9-21: LGTM! Documentation improvements clarify board family support.

The expanded documentation now clearly describes the multiple core board variants (X3568CV2/CV3/CV4) and their compatibility, providing better context for hardware differences while emphasizing maintained compatibility.

26-26: RAM range expansion documented.

Updated to reflect the full 2-16 GB RAM range across board variants, compared to the previous 2-8 GB range.

390-410: LGTM! U-Boot device tree pinctrl matches kernel device trees.

The gmac0/gmac1 pinctrl-0 configurations are consistent with the simplified format in the kernel device trees (both 6.12 and 6.18), with clkinout references removed. This consistency across bootloader and kernel ensures proper hardware initialization.

790-790: LGTM! PMIC interrupt pin configuration consistent with kernel DT.

Comment @coderabbitai help to get the list of available commands and usage tips.

@rbqvq

This comment was marked as resolved.

Sign in to view
@github-actions github-actions bot added the Ready to merge Reviewed, tested and ready for merge label Nov 8, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2025

✅ This PR has been reviewed and approved — all set for merge!

@github-actions github-actions bot removed the Needs review Seeking for review label Nov 8, 2025
@igorpecovnik igorpecovnik merged commit 2b4e874 into armbian:main Nov 8, 2025
1 check passed
@coderabbitai coderabbitai bot mentioned this pull request Dec 12, 2025
Closed
6 tasks
@rbqvq rbqvq deleted the x3568v4 branch February 4, 2026 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igorpecovnik igorpecovnik igorpecovnik approved these changes

@ColorfulRhino ColorfulRhino Awaiting requested review from ColorfulRhino ColorfulRhino is a code owner

@SuperKali SuperKali Awaiting requested review from SuperKali SuperKali is a code owner

@Tonymac32 Tonymac32 Awaiting requested review from Tonymac32 Tonymac32 is a code owner

@amazingfate amazingfate Awaiting requested review from amazingfate amazingfate is a code owner

@catalinii catalinii Awaiting requested review from catalinii catalinii is a code owner

@efectn efectn Awaiting requested review from efectn efectn is a code owner

@paolosabatino paolosabatino Awaiting requested review from paolosabatino paolosabatino is a code owner

@pyavitz pyavitz Awaiting requested review from pyavitz pyavitz is a code owner

@rpardini rpardini Awaiting requested review from rpardini rpardini is a code owner

@HeyMeco HeyMeco Awaiting requested review from HeyMeco HeyMeco is a code owner

@JohnTheCoolingFan JohnTheCoolingFan Awaiting requested review from JohnTheCoolingFan JohnTheCoolingFan is a code owner

@TRSx80 TRSx80 Awaiting requested review from TRSx80

@TheSnowfield TheSnowfield Awaiting requested review from TheSnowfield TheSnowfield is a code owner

@ahoneybun ahoneybun Awaiting requested review from ahoneybun ahoneybun is a code owner

@brentr brentr Awaiting requested review from brentr brentr is a code owner

@chainsx chainsx Awaiting requested review from chainsx chainsx is a code owner

@clee clee Awaiting requested review from clee

@joekhoobyar joekhoobyar Awaiting requested review from joekhoobyar joekhoobyar is a code owner

@krachlatte krachlatte Awaiting requested review from krachlatte krachlatte is a code owner

@lanefu lanefu Awaiting requested review from lanefu lanefu is a code owner

@prahal prahal Awaiting requested review from prahal prahal is a code owner

@schwar3kat schwar3kat Awaiting requested review from schwar3kat schwar3kat is a code owner

Assignees

No one assigned

Labels

11 Milestone: Fourth quarter release Hardware Hardware related like kernel, U-Boot, ... Patches Patches related to kernel, U-Boot, ... Ready to merge Reviewed, tested and ready for merge size/large PR with 250 lines or more

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rbqvq @igorpecovnik