add support for additional arbitrary tweaks to the verifying key, par…#1
Closed
arminsabouri wants to merge 5 commits intoadd-secp256k1-trfrom
Closed
add support for additional arbitrary tweaks to the verifying key, par…#1arminsabouri wants to merge 5 commits intoadd-secp256k1-trfrom
arminsabouri wants to merge 5 commits intoadd-secp256k1-trfrom
Conversation
…tial signatures and signature aggregation
stevenroose
suggested changes
Feb 14, 2024
stevenroose
left a comment
stevenroose
left a comment
There was a problem hiding this comment.
sorry, ended up repeating that comment a ton of times :/
frost-core/src/lib.rs
Outdated
| )] | ||
| message: Vec<u8>, | ||
| /// Additional tweak for both the secret share and the verifying key | ||
| #[cfg_attr(feature = "serde", serde(skip))] |
There was a problem hiding this comment.
Shouldn't skip the serialization of this
Owner
Author
@stevenroose all good. I actually wanted specific feedback on that. |
Owner
Author
|
Closing replaced by #2 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tial signatures and signature aggregation