Sign round3 results with verifying share#3
Draft
arminsabouri wants to merge 2 commits intofeature/final-additional-tweakfrom
Draft
Sign round3 results with verifying share#3arminsabouri wants to merge 2 commits intofeature/final-additional-tweakfrom
arminsabouri wants to merge 2 commits intofeature/final-additional-tweakfrom
Conversation
lamafab
approved these changes
Mar 27, 2025
lamafab
left a comment
lamafab
left a comment
There was a problem hiding this comment.
Concept ACK.
I cannot judge those hand-implemented signature creation and verification mechanisms. Maybe it's worth it to use higher-level abstractions for this? Unless you're confident that this is safe, would like a second opinion on this - Claude.AI says it looks okay, though :)
|
|
||
| let vpk = public_key_package.verifying_key(); | ||
| let G = <Secp256K1Sha256TR as Ciphersuite>::Group::generator(); | ||
| // TODO: figure out ordering of keys in public_key_package and signatures |
There was a problem hiding this comment.
It would probably be better to use a BTreeMap type for attestations.
Owner
Author
Only as confident as you are. This code should be audited by a thirdparty |
arminsabouri
force-pushed
the
round3-attestations
branch
from
040da2f to
9a8133d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.