Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
sudoFerraz
requested changes
Apr 2, 2024
| const contributionRequest = await createContributionRequest( | ||
| teamId, | ||
| session.accessToken!, | ||
| session!.user!.email!, |
Member
There was a problem hiding this comment.
let's check that the session.user exist with an if condition, using "!" on the backend could cause several issues
Comment on lines
27
to
28
| return NextResponse.json({ | ||
| success: true, |
Member
There was a problem hiding this comment.
Did we double check if no api query handler is using the userCredDtos[] field on the api response?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it possible to turn off the ec2 backend buy moving the request creation from cred-manager to backend
Description
What type of PR is this? (check all applicable)
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Checklist:
[optional] Are there any post-deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?