Skip to content

Conversation

@arnested
Copy link
Owner

@arnested arnested commented May 28, 2025

  • Fix golangci-lint warning
  • Avoid deprecated types
  • Use longer variable name
  • Avoid keeping an entrygroup locked

@codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 30.81%. Comparing base (720986d) to head (8d871eb).
Report is 8 commits behind head on main.

Files with missing lines Patch % Lines
entry_groups.go 0.00% 7 Missing ⚠️
container.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
- Coverage   30.98%   30.81%   -0.18%     
==========================================
  Files           7        7              
  Lines         355      357       +2     
==========================================
  Hits          110      110              
- Misses        243      245       +2     
  Partials        2        2              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arnested arnested force-pushed the harden-entrygroups branch from d3437cd to 891bb1d Compare June 26, 2025 10:07
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jun 26, 2025
@arnested arnested force-pushed the harden-entrygroups branch from 891bb1d to 8d871eb Compare June 26, 2025 10:08
@arnested arnested merged commit 3c5a7d1 into main Jun 27, 2025
23 of 25 checks passed
@arnested arnested deleted the harden-entrygroups branch June 27, 2025 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants