Fix duplicate atoms created by setValue() with incomplete LaTeX#2964
Open
Meinzzzz wants to merge 1 commit intoarnog:masterfrom
Open
Fix duplicate atoms created by setValue() with incomplete LaTeX#2964Meinzzzz wants to merge 1 commit intoarnog:masterfrom
Meinzzzz wants to merge 1 commit intoarnog:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull requests aims at fixing a rendering/syncing issue, where by useing setValue() calls with incomplete LaTeX (for example \sum_{ and similar constructs) could created duplicates.
The fix changes atomIsInRange() so atoms that are already offset-in-range are considered in-range even when no non-sentinel child exists.
This ensures deletion includes partially formed atoms created from incomplete LaTeX input, preventing accumulation across sync/update cycles.