You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is a critical optimization that makes it significantly faster.
ok, well, but how much faster? do you have a benchmark?
how many times is that function (isHeaderLine) called?
e.g., if i have a file with 1M lines, but the header is just the first line, i would expect it to be called ~ once or twice (then it would be unnecessary to optimize it at all); if it's called 1M times, is it necessary?
i have updated the diff and tested it on this BED file:
chr start end name score strand
NC_045512.2 0 29903 sars2 . +
bedtools v2.29.2 can read this file
bedtools v2.30.0 is broken
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see the comments in 48105b0
the two versions of
isHeaderLineare not equivalent and the commit broke reading correct BED files