Fix HelloPodDeploymentOpenShiftITCase by removing Gitea dependency#1411
Fix HelloPodDeploymentOpenShiftITCase by removing Gitea dependency#1411striver-24 wants to merge 2 commits intoarquillian:mainfrom
Conversation
- Remove @ignore annotation to allow test execution - Replace build-from-source approach with pre-built WildFly image - Remove RequiresRemoteResource dependency - Add runtime admin user creation instead of build-time setup - Enhance readiness probe to validate WildFly management API - Expose management port (9990) alongside application port (8080) Resolves CI failures in CRC environments by eliminating Gitea operator requirement while maintaining comprehensive WildFly server testing functionality.
|
Hi @striver-24 - and thanks for contributing to Arquillian Cube! ❤️ Just one general note: this PR is not providing a different approach for Cube to deploy and use a Git service, which is still a valid use case. |
|
Thanks for the feedback @fabiobrz I'll duplicate the test case and apply my solution to the new one to validate the build from source approach, keeping the Git service use case separate. |
|
Awesome, thanks @striver-24! |
… build from source approach, keeping the Git service use case separate.
|
Hi @striver-24 - I've tried running the test locally and it does not pass. Could you try as well and confirm? |
Basically what happens here is that Cube will not take the |
| import org.junit.experimental.categories.Category; | ||
| import org.junit.runner.RunWith; | ||
|
|
||
| @Category({RequiresOpenshift.class, RequiresOlm.class}) |
There was a problem hiding this comment.
Since you removed the dependency on Gitea, then no operator requirement is needed, and this can be removed.
|
|
||
| @Category({RequiresOpenshift.class, RequiresOlm.class}) | ||
| @RequiresOpenshift | ||
| @RequiresOlm |
There was a problem hiding this comment.
Since you removed the dependency on Gitea, then no operator requirement is needed, and this can be removed.
| public void shouldBeAbleToInjectURL() throws Exception { | ||
| Assert.assertNotNull(base); | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Minor thing: could you add a new empty line at EoF, please?
| } | ||
| }] | ||
| } | ||
| } No newline at end of file |
There was a problem hiding this comment.
Minor thing: could you add a new empty line at EoF, please?
|
Appreciate the feedback, @fabiobrz I plan to have it resolved in the next day or two. |
Thanks @striver-24 - great job so far, and I think the required changes are pretty straightforward now, so feel free to ping me once you're done with those, and I'll be glad to review them. |
|
Hi @striver-24 - doing some cleanup 🙂 |
2 participants
Short description of what this resolves:
The
HelloPodDeploymentOpenShiftITCasewas being skipped due to Gitea operator deployment failures in CI environments using CRC (CodeReady Containers). The test was marked with@Ignore("Needs the Gitea operator, which Arquillian Cube tries to provision, but it does not work on GitHub CI which uses CRC").Changes proposed in this pull request:
This PR eliminates the Gitea dependency by switching from build-from-source to a pre-built image approach while preserving all original testing functionality.
Fixes #