Open
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
rrivera747
reviewed
Mar 19, 2026
| ");' " + chkDefaults[i] + "><label for='hudCheckbox" + i + "' >" + chkLabels[i] + "</label>"; | ||
| str += "</div>"; | ||
|
|
||
| var radioLabels = ["Tile","Replace","Superimpose (1D/Profile/Graph)"]; //test; FIXME superimpose is broken in jsroot v5.9.0 and v7.9.0 usage of this gui, "Superimpose"]; |
Contributor
There was a problem hiding this comment.
What is the 'test' comment? If this is working now, we should remove the "FIXME"
rrivera747
reviewed
Mar 19, 2026
| else //return to showing current directory | ||
| ViewerRoot.hud.changeDirectory(getPath(currDirPtr)); //return and refresh directory contents from server | ||
| } //end toggleAdminControls() | ||
| if(!ViewerRoot.hudAutoHide) return self.handleWindowResize(); //if not autohide lock size |
Contributor
There was a problem hiding this comment.
Is this intentional to have self replace ViewerRoot and ViewerRoot.hud? Was this a bug that you are fixing?
Author
There was a problem hiding this comment.
Yes, intentional. self keeps the correct HUD object inside the callback, because this may change there.
rrivera747
reviewed
Mar 19, 2026
rrivera747
requested changes
Mar 19, 2026
Contributor
rrivera747
left a comment
rrivera747
left a comment
There was a problem hiding this comment.
There are some merge conflicts to resolve. And I left some comments to be resolved.
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
MarkmVak
force-pushed
the
mvakulen/superimpose
branch
from
3aebee4 to
1aedcec
Compare
| var animationTargetTop, isDropDownAnimating, isDropDownDown; | ||
|
|
||
| var hudDirBrowserDiv; | ||
| var hudAdminSettingsDiv; |
Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.