Fixed the Problem (Step 2): Unable to Identifying Certain Data File T…#2048
Open
Meghanxuxx wants to merge 1 commit intoartefactual:qa/1.xfrom
Open
Fixed the Problem (Step 2): Unable to Identifying Certain Data File T…#2048Meghanxuxx wants to merge 1 commit intoartefactual:qa/1.xfrom
Meghanxuxx wants to merge 1 commit intoartefactual:qa/1.xfrom
Conversation
5 tasks
Member
|
@Meghanxuxx I think this has similar problems to artefactual/archivematica-storage-service#772 (comment). The |
Contributor
|
Hi @Meghanxuxx - just letting your know we're going to test 1.18 in a few weeks and will stop accepting contributions for it. If you have any questions about the failing tests, do let us know. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: archivematica/Issues#1745
This PR is still continuing to solve the Issue #1745, the solution is split into two PRs because both the stroge service files and the archivematica files need to be modified, and here's the first part: artefactual/archivematica-storage-service#772
If the step1 PR change is taken, the only issue left now is that files extracted using extract_contents.py will end up with different file paths than they did with function extract_and_remove_bundle. The new paths include dates like:
archivematica/src/archivematica/MCPClient/clientScripts/extract_contents.py
Line 34 in ad01b68
So we need to fix the get_db_objects function in parse_dataverse_mets.py to make sure all files can be correctly matched using the pattern "[original_directory].zip-[timestamp]/[original_file_path]"
This PR modifies the get_db_objects function, which now searches for files in the database using three different methods: