Open
Conversation
- Forward the metadata XML validation dictionary to the resolver when parsing XSD schemas themselves. - Always check the dictionary first before falling back to resolving the original schemaLocation. - Implement a timeout for schema URL requests. This change should provide a way forward for broken external schema resources, potentially prevent being rate-limited or blocked by external sites, and overall stop or heavily reduce outgoing schema-related traffic (while possibly decreasing loading times). Additionally, it will enable the user to have a more controlled local schema file catalog for security concerns.
5 tasks
replaceafill
added
the
Community
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
archivematica/Issues#1786
This change should provide a way forward for broken external schema resources, potentially prevent being rate-limited or blocked by external sites, and overall stop or heavily reduce outgoing schema-related traffic (while possibly decreasing loading times). Additionally, it will enable the user to have a more controlled local schema file catalog for security concerns.