Conversation
src/SEOTools/SEOMeta.php
Outdated
| // if $href is empty jump to next | ||
| if (empty($href)) { | ||
| continue; | ||
| } |
There was a problem hiding this comment.
I think this check is unnecessary: since the addPreload function already requires both href & as to be present.
There was a problem hiding this comment.
yes, you are right. removing it.
src/SEOTools/Facades/SEOMeta.php
Outdated
| * @method static \Artesaos\SEOTools\Contracts\MetaTags removeMeta(string $key) | ||
| * @method static \Artesaos\SEOTools\Contracts\MetaTags addMeta(array|string $meta, string|null $value = null, string $name = 'name') | ||
| * @method static \Artesaos\SEOTools\Contracts\MetaTags addPreload(string $href, string $as) | ||
| * @method static \Artesaos\SEOTools\Contracts\MetaTags addCustom(array|string $meta) |
There was a problem hiding this comment.
| * @method static \Artesaos\SEOTools\Contracts\MetaTags addCustom(array|string $meta) | |
| * @method static \Artesaos\SEOTools\Contracts\MetaTags addCustom(string $meta) |
J-Brk
left a comment
J-Brk
left a comment
There was a problem hiding this comment.
Thank you for very much for your contribution! I have reviewed your submit an found a few minor things that do need to be addressed. Please review then and adjust them where needed.
|
updated the files as per your comments. Thanks! |
|
Very nice @sp4r74cus |
If he doesn't make any tests; I will make them in a different commit; since I think this would be an great feature to add to make this package more universal. |
|
There is a conflict @J-Brk Also, shold be good do the test with it. |
|
Dear @vinicius73 & @J-Brk, |
|
3 participants
Added support for preload links:
https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/rel/preload
Also, to have the ability to add any other meta tag that is not yet supported i added a custom array that takes a raw html tag and adds it in the header.