You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I've been having display/animation issues when working with WidgetWrapper.astro.
In some cases the intersect would not trigger the fade-in animations. Looking into it I found myself in components/common/BasicScripts.astro and found the intersect implementation.
Then i found those references to some css class called intercept-no-queue that had no definition.
Noticed the logic linked to the css class intersect-no-queue a saw it was not used anywhere in the code.
After reconnecting those two bits I am no longer having display/animation issues when working with WidgetWrapper.astro.
We can also see the css class intercept-no-queue being added to elements in ItemGrid2.astro, WidgetWrapper.astro, Footer.astro, Hero.astro and Hero2.astro.
Later on, in commit #740b96c we see the name changed from intercept-no-queue to intersect-no-queue but no corresponding changes to the elements that were tagged with the css class intercept-no-queue.
It looks like it's either the name intercept-no-queue in BasicScripts.astro that was changed by mistake, or the the css class name inadvertently were not updated in the widgets.
My personal opinion is to keep using the new name intersect-no-queue as it is directly related to the intersect functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been having display/animation issues when working with
WidgetWrapper.astro.In some cases the intersect would not trigger the fade-in animations. Looking into it I found myself in
components/common/BasicScripts.astroand found theintersectimplementation.Then i found those references to some css class called
intercept-no-queuethat had no definition.Noticed the logic linked to the css class
intersect-no-queuea saw it was not used anywhere in the code.After reconnecting those two bits I am no longer having display/animation issues when working with
WidgetWrapper.astro.