feat: per-user approval settings and content item deletion#8
Merged
iabouhashish merged 8 commits intomainfrom Apr 2, 2026
Merged
feat: per-user approval settings and content item deletion#8iabouhashish merged 8 commits intomainfrom
iabouhashish merged 8 commits intomainfrom
Conversation
New TypeScript types (UserSettings, UserSettingsResponse) and API methods
for per-user settings (GET/PUT /v1/users/me/settings) and content item
deletion (DELETE /v1/content/{contentType}/{fileId}).
New hooks: useUserSettings, useUpdateUserSettings, useDeleteContentItem.
Uploaded content items now show a delete icon button. Clicking it opens a confirmation dialog before permanently removing the item via the API. Deletion only shown for items with extractable UUID file IDs (uploaded files). Fixes: UUID regex now enforces lowercase, error toast on delete failure, and typo fix in release_notes path check.
New MySettingsPanel component and tab in Settings. Users can toggle their personal require_approval override (on/off) or reset to the global default. Shows loading skeleton during fetch, disables controls during save.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- settings/page.test.tsx: mock useUserSettings + useUpdateUserSettings so MySettingsPanel renders without hitting the real API - setup.ts: suppress MUI anchorEl warning (jsdom has no layout engine) and the intentional getPipelineSettings fallback warn (test mock rejects by design)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Per-user Settings (My Settings tab)
Content Item Deletion
Under the hood
UserSettings,UserSettingsResponsegetUserSettings,updateUserSettings,deleteContentItemuseUserSettings,useUpdateUserSettings,useDeleteContentItemTest Coverage
Tests: 54 → 68 (+14 new across 2 files)
Pre-Landing Review
4 issues found, all auto-fixed:
content-list.tsx:50— typo/release_notess/→/release_notes/(would never match)settings/page.tsx:109— removed non-functionalindeterminateprop from MUI Switchcontent-list.tsx:34— UUID regex/iflag removed (enforces lowercase, prevents 404s on case-sensitive storage)content-list.tsx:121— silent catch block →showErrorToast('Failed to delete item')Design Review
Frontend files changed — design review (lite) applied. Findings:
Greptile Review
No Greptile comments.
Plan Completion
No plan file detected.
Verification Results
No dev server detected — skipping plan verification.
Test plan
🤖 Generated with Claude Code