Skip to content

Fix Y2038 timestamp overflow in rsyslog plugin timestamp formatter #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Y2038 timestamp overflow in rsyslog plugin timestamp formatter #17

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efd13b4
Fix Y2038 timestamp overflow in rsyslog plugin timestamp formatter
devin-ai-integration[bot] Jan 15, 2026
b40a601
Fix type mismatch in localtime_r call
devin-ai-integration[bot] Jan 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/sonic-eventd/rsyslog_plugin/timestamp_formatter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,13 @@ string TimestampFormatter::getYear(string timestamp) {
}
}
// no last timestamp or year change
// Use thread-safe localtime_r instead of localtime
// On 64-bit systems, time_t is already 64-bit and Y2038-safe
time_t currentTime = time(nullptr);
tm* const localTime = localtime(&currentTime);
struct tm tm_result;
localtime_r(&currentTime, &tm_result);
stringstream ss;
auto currentYear = 1900 + localTime->tm_year;
auto currentYear = 1900 + tm_result.tm_year;
ss << currentYear; // get current year
string year = ss.str();
m_storedTimestamp = timestamp;
Expand Down
Loading