Skip to content

Update sonic-mgmt-common and sonic-mgmt-framework submodules for AAA Klish CLI#18

Open
huanlev wants to merge 7 commits intomasterfrom
devin/1769812756-aaa-submodule-update
Open

Update sonic-mgmt-common and sonic-mgmt-framework submodules for AAA Klish CLI#18
huanlev wants to merge 7 commits intomasterfrom
devin/1769812756-aaa-submodule-update

Conversation

@huanlev
Copy link
Collaborator

@huanlev huanlev commented Jan 30, 2026

Why I did it

This PR updates the sonic-mgmt-common and sonic-mgmt-framework submodules to include the implementation of Klish-based AAA (Authentication, Authorization, Accounting) CLI commands with OpenConfig to SONiC transformation.

Work item tracking
  • Microsoft ADO (number only): N/A

How I did it

Updated submodule references to include:

  • sonic-mgmt-common (4ffb6e4): AAA transformer functions and YANG annotations for bidirectional OpenConfig ↔ SONiC translation
  • sonic-mgmt-framework (3c0dd26): Klish XML command definitions, Python actioners, and Jinja2 templates for AAA CLI

Related submodule PRs:

Updates since last revision

Fixed build errors in xfmr_aaa.go:

  • Type assertion fix: Replaced direct type assertions on union types with type switches using proper wrapper struct types (e.g., OpenconfigSystem_System_Aaa_Authentication_Config_AuthenticationMethod_Union_E_OpenconfigAaaTypes_AAA_METHOD_TYPE)
  • Removed non-existent OpenConfig fields: Removed references to Failthrough, Fallback, Debug, Trace fields which don't exist in the standard OpenConfig AAA model (these are SONiC-specific extensions)
  • Added helper functions: extractAuthMethodString, extractAuthzMethodString, extractAcctMethodString for extracting method strings from union types
  • Updated unit tests: Tests now match the fixed code structure

How to verify it

  1. Review the submodule PRs for the actual implementation details
  2. CI build should compile both packages successfully
  3. Unit tests in sonic-mgmt-common should pass

Human Review Checklist:

  • Verify the removal of Failthrough/Fallback/Debug/Trace fields is acceptable (these are SONiC-specific, not in standard OpenConfig AAA)
  • Review union type handling in extractAuthMethodString and similar functions
  • Check that DbToYang_aaa_subtree_xfmr correctly wraps enum values in union wrapper structs
  • Verify YANG annotations in openconfig-aaa-annot.yang are correct
  • Check CLI commands in aaa.xml match expected AAA functionality

Which release branch to backport (provide reason below if selected)

  • 202305
  • 202311
  • 202405
  • 202411
  • 202505
  • 202511

Tested branch (Please provide the tested image version)

  • Pending CI build verification

Description for the changelog

Add Klish-based AAA CLI commands with OpenConfig to SONiC transformation support

Link to config_db schema for YANG module changes

N/A - Uses existing AAA table schema

Link to Devin run

https://cisco-demo.devinenterprise.com/sessions/239c6c349b7349a388ecaffa812b80ce

Requested by: @huanlev


Open with Devin

…Klish CLI

This commit updates the submodule references to include:
- sonic-mgmt-common: AAA transformer and YANG annotations for OpenConfig to SONiC translation
- sonic-mgmt-framework: Klish-based AAA CLI commands with OpenConfig to SONiC transformation

Related PRs:
- sonic-mgmt-common: arthur-cog-sonic/sonic-mgmt-common#2
- sonic-mgmt-framework: arthur-cog-sonic/sonic-mgmt-framework#1

Co-Authored-By: huanle@cisco.com <huanle@cisco.com>
@devin-ai-integration
Copy link

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

- Fix type assertion errors by using proper union wrapper types
- Remove references to non-existent OpenConfig fields (Failthrough, Fallback, Debug, Trace)
- Add helper functions for extracting method strings from union types
- Update unit tests to match fixed code

Co-Authored-By: huanle@cisco.com <huanle@cisco.com>
Copy link

@devin-ai-integration devin-ai-integration bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no potential bugs to report.

View in Devin Review to see 1 additional flag.

Open in Devin Review

devin-ai-integration bot and others added 5 commits February 5, 2026 05:51
…t tests

- Add explicit /openconfig-system:system/aaa path registration in common_app.go
- Add unit tests to validate OpenConfig AAA xpath requests are handled by common_app

Co-Authored-By: huanle@cisco.com <huanle@cisco.com>
Co-Authored-By: huanle@cisco.com <huanle@cisco.com>
Co-Authored-By: huanle@cisco.com <huanle@cisco.com>
Co-Authored-By: huanle@cisco.com <huanle@cisco.com>
…ssue

Co-Authored-By: huanle@cisco.com <huanle@cisco.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant