Update sonic-mgmt-common and sonic-mgmt-framework submodules for AAA Klish CLI#18
Open
Update sonic-mgmt-common and sonic-mgmt-framework submodules for AAA Klish CLI#18
Conversation
…Klish CLI This commit updates the submodule references to include: - sonic-mgmt-common: AAA transformer and YANG annotations for OpenConfig to SONiC translation - sonic-mgmt-framework: Klish-based AAA CLI commands with OpenConfig to SONiC transformation Related PRs: - sonic-mgmt-common: arthur-cog-sonic/sonic-mgmt-common#2 - sonic-mgmt-framework: arthur-cog-sonic/sonic-mgmt-framework#1 Co-Authored-By: huanle@cisco.com <huanle@cisco.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
- Fix type assertion errors by using proper union wrapper types - Remove references to non-existent OpenConfig fields (Failthrough, Fallback, Debug, Trace) - Add helper functions for extracting method strings from union types - Update unit tests to match fixed code Co-Authored-By: huanle@cisco.com <huanle@cisco.com>
…t tests - Add explicit /openconfig-system:system/aaa path registration in common_app.go - Add unit tests to validate OpenConfig AAA xpath requests are handled by common_app Co-Authored-By: huanle@cisco.com <huanle@cisco.com>
Co-Authored-By: huanle@cisco.com <huanle@cisco.com>
Co-Authored-By: huanle@cisco.com <huanle@cisco.com>
Co-Authored-By: huanle@cisco.com <huanle@cisco.com>
…ssue Co-Authored-By: huanle@cisco.com <huanle@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
This PR updates the sonic-mgmt-common and sonic-mgmt-framework submodules to include the implementation of Klish-based AAA (Authentication, Authorization, Accounting) CLI commands with OpenConfig to SONiC transformation.
Work item tracking
How I did it
Updated submodule references to include:
Related submodule PRs:
Updates since last revision
Fixed build errors in
xfmr_aaa.go:OpenconfigSystem_System_Aaa_Authentication_Config_AuthenticationMethod_Union_E_OpenconfigAaaTypes_AAA_METHOD_TYPE)Failthrough,Fallback,Debug,Tracefields which don't exist in the standard OpenConfig AAA model (these are SONiC-specific extensions)extractAuthMethodString,extractAuthzMethodString,extractAcctMethodStringfor extracting method strings from union typesHow to verify it
Human Review Checklist:
extractAuthMethodStringand similar functionsDbToYang_aaa_subtree_xfmrcorrectly wraps enum values in union wrapper structsopenconfig-aaa-annot.yangare correctaaa.xmlmatch expected AAA functionalityWhich release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Add Klish-based AAA CLI commands with OpenConfig to SONiC transformation support
Link to config_db schema for YANG module changes
N/A - Uses existing AAA table schema
Link to Devin run
https://cisco-demo.devinenterprise.com/sessions/239c6c349b7349a388ecaffa812b80ce
Requested by: @huanlev