Fix local build failures: libnl3 test propagation and Rust lockfile#20
Open
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Open
Fix local build failures: libnl3 test propagation and Rust lockfile#20devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
devin-ai-integration[bot] wants to merge 1 commit intomasterfrom
Conversation
- libnl3: Forward DEB_BUILD_OPTIONS to dpkg-buildpackage in native build path so that nocheck is respected when BUILD_SKIP_TEST=y, fixing test failures in containerized build environments where netlink interface creation is unavailable - sonic-supervisord-utilities-rs: Add --locked flag to cargo install to force use of Cargo.lock, preventing dependency re-resolution that pulls newer crate versions incompatible with the installed rustc version Co-Authored-By: Arthur Poon <arthur.poon@windsurf.com>
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Two issues were discovered when attempting a local SONiC VS image build:
libnl3 test failures in containerized builds: The native (non-cross) build path in
src/libnl3/Makefiledid not explicitly forward theDEB_BUILD_OPTIONSenvironment variable todpkg-buildpackage. While env vars should propagate by default, this makes the forwarding explicit (matching the cross-build path which already passes-Pcross,nocheck). The libnl3 test suite (tests/check-all) attempts to create network interfaces via netlink, which fails in nested Docker environments with error-10(NLE_OBJ_NOTFOUND).Rust dependency version drift: The
cargo install --path .command insonic-supervisord-utilities-rs/Makefilere-resolves dependencies from crates.io, ignoringCargo.lock. This pulledtime@0.3.47which requires rustc 1.88.0, but the sonic-slave container ships rustc 1.86.0.Work item tracking
How I did it
libnl3: Added explicit
DEB_BUILD_OPTIONS="$$DEB_BUILD_OPTIONS"prefix to thedpkg-buildpackagecall in the native build path, ensuringnocheckis respected whenBUILD_SKIP_TEST=y.sonic-supervisord-utilities-rs: Added
--lockedflag tocargo installto force use ofCargo.lock, preventing dependency re-resolution.How to verify it
The build should progress past both libnl3 and sonic-supervisord-utilities-rs without failures.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Fix local build failures by forwarding DEB_BUILD_OPTIONS to libnl3 dpkg-buildpackage and adding --locked to cargo install for sonic-supervisord-utilities-rs
Human Review Checklist
DEB_BUILD_OPTIONSforwarding is actually necessary (env vars should propagate by default - this may be redundant)--lockedis appropriate forcargo installin the Debian package build contextcargo installpatterns that need the same fixLink to config_db schema for YANG module changes
N/A
Link to Devin run: https://cisco-demo.devinenterprise.com/sessions/9043b312451b437c96397725e0b27047
Requested by: @arthurkkp-cog