Skip to content

fix(core): cascade delete artifact record on model deletion #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arthur2jolly merged 1 commit into from
Mar 22, 2026
Merged

fix(core): cascade delete artifact record on model deletion #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions app/Core/Models/Concerns/HasArtifactIdentifier.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,10 @@ trait HasArtifactIdentifier
{
public static function bootHasArtifactIdentifier(): void
{
static::deleting(function (self $model) {
$model->artifact()->delete();
});

static::created(function (self $model) {
DB::transaction(function () use ($model) {
$projectId = $model->getProjectIdForArtifact();
Expand Down
27 changes: 25 additions & 2 deletions tests/Feature/EdgeCases/SpecificationEdgeCasesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,8 +447,31 @@ public function mcpTools(): array
$this->assertDatabaseMissing('stories', ['id' => $story->id]);
});

it('cleans up the artifact record when a story is deleted')
->skip('HasArtifactIdentifier does not register a deleting hook — artifact cascade not yet implemented in core.');
it('cleans up the artifact record when a story is deleted', function (): void {
$auth = createAuth();
$project = setupProject($auth, ['code' => 'CL9B']);
app(TenantManager::class)->setTenant($auth['tenant']);

$epic = Epic::factory()->create(['project_id' => $project->id]);
$story = Story::factory()->create(['epic_id' => $epic->id]);
$storyId = $story->fresh()->identifier;

$this->assertDatabaseHas('artifacts', [
'artifactable_id' => $story->id,
'artifactable_type' => $story->getMorphClass(),
]);

$this->deleteJson(
"/api/v1/projects/CL9B/stories/{$storyId}",
[],
authHeader($auth['token'])
)->assertStatus(204);

$this->assertDatabaseMissing('artifacts', [
'artifactable_id' => $story->id,
'artifactable_type' => $story->getMorphClass(),
]);
});

});

Expand Down
Loading