build: Fix clang compiliation by decontaminating build environment#68
Open
salahcoronya wants to merge 1 commit intoarthurdejong:masterfrom
Open
build: Fix clang compiliation by decontaminating build environment#68salahcoronya wants to merge 1 commit intoarthurdejong:masterfrom
salahcoronya wants to merge 1 commit intoarthurdejong:masterfrom
Conversation
4 tasks
salahcoronya
force-pushed
the
build-decontamination
branch
from
2f6ebe5 to
e0dc46d
Compare
…clang The statements in configure.ac "pollute" the environmental variables. This causes problem when --enable-warnings is set and clang is the compiler. It only works by accident on gcc because gcc aborts on illegal flags anyway, but clang does not which causes -Werror to get added to the check. One of the warning conflicts with that, causing it to be uncompiliable under clang. This patch removes the environmental polluation by storing the flags in automake variables. The flags are then added by automake. Also, there already a function in autoconf-archive to determine valid flags, so use that instead of the hand-rolled one. Signed-off-by: Christopher Byrne <salah.coronya@gmail.com>
salahcoronya
force-pushed
the
build-decontamination
branch
from
e0dc46d to
21ced2d
Compare
gentoo-bot
pushed a commit
to gentoo/gentoo
that referenced
this pull request
Jul 8, 2024
Upstream pull request: arthurdejong/nss-pam-ldapd#68 Closes: https://bugs.gentoo.org/832002 Signed-off-by: Christopher Byrne <salah.coronya@gmail.com> Closes: #37304 Signed-off-by: Matthew Thode <prometheanfire@gentoo.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The statements in configure.ac "pollute" the environmental variables. This causes problem when --enable-warnings is set and clang is the compiler. It only works by accident on gcc because gcc aborts on illegal flags anyway, but clang does not which causes -Werror to get added to the check. One of the warning conflicts with that, causing it to be uncompiliable under clang.
This patch removes the environmental polluation by storing the flags in automake variables. The flags are then added by automake. Also, there already a function in autoconf-archive to determine valid flags, so use that instead of the hand-rolled one.