Fix: canceled requests no longer propagate errors to deduplicated requests

[Copilot]

When a request with deduplication is canceled, it was rejecting the shared deferred, causing all waiting requests to fail with ERR_CANCELED. Subsequent requests for the same resource would fail even though they weren't canceled.

Example of the issue:

const axios = setupCache(Axios.create());

const controller = new AbortController();
const req1 = axios.get('/api/data', { signal: controller.signal });
const req2 = axios.get('/api/data'); // Deduplicates, waits on req1's deferred

controller.abort(); // Aborts req1

await req1; // ❌ Fails with ERR_CANCELED (expected)
await req2; // ❌ Also fails with ERR_CANCELED (bug - should succeed)

Changes

Response interceptor (src/interceptors/response.ts)

• ERR_CANCELED now resolves the deferred instead of rejecting it
• Waiting requests proceed with their own network call
• Cache cleanup remains unchanged

Test coverage (test/interceptors/abort-request.test.ts)

• Sequential abort/retry scenario
• Immediate abort/retry (issue reproduction)
• Multiple concurrent requests after abort

Updated expectations (test/interceptors/response.test.ts)

• "Cancelled deferred" test now expects waiting requests to succeed

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• REDACTED-url.lan
  • Triggering command: /usr/local/bin/node /usr/local/bin/node --import ./test/setup.js --enable-source-maps /home/REDACTED/work/axios-cache-interceptor/axios-cache-interceptor/test/interceptors/stale-if-error.test.ts (dns block)
  • Triggering command: /usr/local/bin/node /usr/local/bin/node --import ./test/setup.js --enable-source-maps /home/REDACTED/work/axios-cache-interceptor/axios-cache-interceptor/test/interceptors/stale-if-error.test.ts test/interceptors/hydrate.test.ts test/interceptors/last-modified.test.ts test/interceptors/request.test.ts test/interceptors/response.test.ts test/interceptors/stale-if-error.test.ts test/interceptors/util.test.ts test/interceptors/vary.test.ts (dns block)
  • Triggering command: /usr/local/bin/node /usr/local/bin/node --import ./test/setup.js --enable-source-maps /home/REDACTED/work/axios-cache-interceptor/axios-cache-interceptor/test/interceptors/stale-if-error.test.ts --enable-sourceOUTPUT (dns block)
• REDACTED.url.lan
  • Triggering command: /usr/local/bin/node /usr/local/bin/node --import ./test/setup.js --enable-source-maps /home/REDACTED/work/axios-cache-interceptor/axios-cache-interceptor/test/interceptors/response.test.ts (dns block)
  • Triggering command: /usr/local/bin/node /usr/local/bin/node --import ./test/setup.js --enable-source-maps /home/REDACTED/work/axios-cache-interceptor/axios-cache-interceptor/test/interceptors/stale-if-error.test.ts (dns block)
  • Triggering command: /usr/local/bin/node /usr/local/bin/node --import ./test/setup.js --enable-source-maps /home/REDACTED/work/axios-cache-interceptor/axios-cache-interceptor/test/interceptors/response.test.ts test/interceptors/hydrate.test.ts test/interceptors/last-modified.test.ts test/interceptors/request.test.ts test/interceptors/response.test.ts test/interceptors/stale-if-error.test.ts test/interceptors/util.test.ts test/interceptors/vary.test.ts (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Original prompt

---

This section details on the original issue you should resolve

<issue_title>Bug: request fails when a previous request with the same parameters is aborted</issue_title>
<issue_description>### What happened?

Imagine an application that fetches some data when its state changes, and cancels the previous request (even if the relevant parameters for the request haven't necessarily changed).
This might look something like this:

import Axios from "https://cdn.skypack.dev/[email protected]";
import { setupCache } from "https://cdn.skypack.dev/[email protected]";

const axios = setupCache(Axios.create(), {
  interpretHeader: false,
  debug: console.log
});

const abortControler = new AbortController();
const req1 = axios.get("https://dummyjson.com/products", { signal: abortControler.signal });

setTimeout(() => {
  abortControler.abort();
  const req2 = axios.get("https://dummyjson.com/products");
  req2
    .then(() => console.log("this won't happen"))
    .catch(() => console.log("second request has also failed."));
}, 10)

(see https://jsfiddle.net/x5t071yh/3/ )

What happens is that when cache-interceptor is enabled, the second request will also fail. This is counterintuitive.

cheers,
Mehran

axios-cache-interceptor version

v1.11.3

Node / Browser Version

Node 24.12.0 / Chrome 144

Axios Version

v1.13.2

What storage is being used

Memory Storage

Relevant debugging log output

[
    {
        "id": "-95760698",
        "msg": "Making network request",
        "data": {
            "overrideCache": false,
            "cacheState": "empty"
        }
    },
    {
        "id": "-95760698",
        "msg": "Caching response",
        "data": {
            "ttl": 300000,
            "interpretHeader": false
        }
    },
    {
        "id": "-95760698",
        "msg": "Found waiting deferred(s) and resolve them"
    },
    {
        "id": "-95760698",
        "msg": "Response cached successfully",
        "data": {
            "state": "cached",
            "ttl": 300000
        }
    },
    {
        "id": "-95760698",
        "msg": "Using cached response"
    },
    {
        "id": "-95760698",
        "msg": "Returned cached response"
    }
]
```</issue_description>

<agent_instructions>try to reproduce this issue and either open a pr fixing the issue or open a PR adding documentation to teach which options or things the dev must to do solve this problem</agent_instructions>

## Comments on the Issue (you are @copilot in this section)

<comments>
</comments>

• Fixes Bug: request fails when a previous request with the same parameters is aborted #1171

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.77%. Comparing base (41c3a24) to head (44dc1dd).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1172   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          20       20           
  Lines        3092     3099    +7     
  Branches      272      275    +3     
=======================================
+ Hits         3054     3061    +7     
  Misses         36       36           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Copilot]

Pull request overview

This pull request fixes a bug where canceled requests with deduplication were incorrectly propagating ERR_CANCELED errors to all waiting deduplicated requests, causing subsequent requests for the same resource to fail even though they weren't canceled.

Changes:

• Modified response interceptor to resolve deferred promises instead of rejecting them when a request is canceled
• Updated test expectations to reflect that waiting requests should succeed after a cancellation
• Added comprehensive test coverage for various abort scenarios

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File	Description
src/interceptors/response.ts	Modified error handling to resolve deferred for ERR_CANCELED instead of rejecting, allowing waiting requests to make their own network calls
test/interceptors/response.test.ts	Updated existing test expectations to verify waiting requests succeed after first request is canceled
test/interceptors/abort-request.test.ts	Added new comprehensive test suite covering sequential abort/retry, immediate abort/retry, and multiple concurrent requests scenarios

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

The test name "Cancelled deferred propagates error to all waiting requests" is now misleading since the test validates that waiting requests should succeed (not receive the error). Consider updating the test name to reflect the new behavior, such as "Cancelled request does not propagate error to waiting deduplicated requests" or "Waiting requests succeed after first request is cancelled".