feat(test): test IAM setup with CF templates on fresh account#3262
Open
feat(test): test IAM setup with CF templates on fresh account#3262
Conversation
fb76207 to
603973b
Compare
603973b to
f9abdc6
Compare
f9abdc6 to
2c68262
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Two main changes:
1. Merging the two CF templates used for GitHub OIDC IAM setup into one template.
This way the IAM role created will have permission needed to run tests on both Lambda and Fargate, and only one
Launch Stackbutton will be needed in our GitHub Actions guide.2. Adding automated tests for CloudFormation (CF) templates
Testing that the IAM role created from the
github-oidc.ymlCF template has the correct permissions to be able to run Artillery tests on Lambda and Fargate and that the OIDC is set correctly.We do this by building on the
Publish CloudFormation templates to AWS S3Github action creating the following flow:set-up-and-run-artillery-test-on-awsjob runs for both Lambda and Fargate but one at a time:aws-nuke, essentially simulating a fresh accountArtilleryGitHubOIDCRoleIAM role is assumedlambda-smoke.test.jsfor Lambda anddd-adot.test.jsfor Fargate.The action will be triggered by
Publish packages to NPMandPublish packages to NPM (canary)runs. Due to this a canary version of templates has been implemented as well.Pre-merge checklist