Skip to content

Add custom polars Kurucz reader and test#24

Merged
lukeshingles merged 1 commit intomainfrom
testkurucz
Jan 30, 2026
Merged

Add custom polars Kurucz reader and test#24
lukeshingles merged 1 commit intomainfrom
testkurucz

Conversation

@lukeshingles
Copy link
Member

No description provided.

Copilot AI review requested due to automatic review settings January 30, 2026 11:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request adds a custom Polars-based Kurucz data reader to replace the dependency on the carsus library. The PR includes significant changes to the data processing pipeline and introduces breaking changes to the Python and pandas version requirements.

Changes:

  • Implements a custom GFALL parser using Polars instead of relying on carsus
  • Updates minimum Python version from 3.11 to 3.12
  • Updates pandas requirement from 2.3.0 to 3.0.0
  • Adds Kurucz test data and checksums
  • Introduces ARTISATOMIC_TESTMODE environment variable for test isolation

Reviewed changes

Copilot reviewed 9 out of 15 changed files in this pull request and generated 8 comments.

Show a summary per file
File Description
artisatomic/readkuruczdata.py Complete rewrite with custom GFALL parser using polars; replaces carsus dependency
artisatomic/readqubdata.py Adds test mode support via environment variable
pyproject.toml Bumps minimum Python to 3.12 and pandas to 3.0.0; removes Python 3.11 classifier
.github/workflows/test.yml Adds ARTISATOMIC_TESTMODE environment variable; adds kurucz to test matrix; removes QUB rsync step
tests/kurucz/* Adds new test files, checksums, and configuration
tests/qub/checksums.txt Updates checksums for co2.txt and co3.txt
atomic-data-kurucz/.gitignore Updates ignore patterns for new file organization
atomic-data-kurucz/url.txt Changes URL from gfall/ to gfall/zztar
atomic-data-kurucz/test_sample/zztar/* Adds compressed test data files
uv.lock Removes Python 3.11 wheels and updates dependencies

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot AI review requested due to automatic review settings January 30, 2026 11:09
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 9 out of 15 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@lukeshingles lukeshingles merged commit eb0b08a into main Jan 30, 2026
8 checks passed
@lukeshingles lukeshingles deleted the testkurucz branch January 30, 2026 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants