[FIX] add some task checks so that role runs in check mode#19
Open
khartahk wants to merge 1 commit intoartis3n:mainfrom
Open
[FIX] add some task checks so that role runs in check mode#19khartahk wants to merge 1 commit intoartis3n:mainfrom
khartahk wants to merge 1 commit intoartis3n:mainfrom
Conversation
khartahk
changed the title
artis3n
reviewed
Mar 30, 2025
Owner
artis3n
left a comment
artis3n
left a comment
There was a problem hiding this comment.
Thank you for this PR! I've been meaning to get check mode nominally supported. I'll start testing against this PR shortly. Do you believe these are the only changes needed?
| when: | ||
| - tailscale_start is failed | ||
| - tailscale_start.stdout | length > 0 | ||
| - not ansible_check_mode and tailscale_start.stdout | length > 0 |
Owner
There was a problem hiding this comment.
Each item in this list is an "and" statement on the when condition. Can you add a new item to the list instead of combining on this line?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added some checks to fix the role to also run without issues in check mode.