Draft
Conversation
0dbd4ee to
19177be
Compare
Codecov Report
@@ Coverage Diff @@
## devel #150 +/- ##
==========================================
+ Coverage 98.23% 98.25% +0.02%
==========================================
Files 37 71 +34
Lines 1130 1148 +18
==========================================
+ Hits 1110 1128 +18
Misses 20 20 |
17 tasks
This was referenced Feb 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR initiate a large cleanup of the internal API relying on traits to overload the different group/tangent functions for each derived. It cleans up the old API design debt where e.g.
Derived::inversehidesBase::inverse. Going with this new design allows to more easily specialize functions where and if necessary. This will also (hopefully) open the door to,Comes on top of #147.