Skip to content

Conversation

@artoonie
Copy link
Owner

@artoonie artoonie commented Nov 6, 2025

Analyze results to determine if a tie was broken, and present FAQ language explaining it.

Closes #582

@artoonie artoonie force-pushed the feature/tiebreak-faq branch from 6dbcb57 to a6bb228 Compare November 6, 2025 18:57
@artoonie artoonie changed the title Feature/tiebreak faq Tiebreak Support Nov 6, 2025
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

❌ Patch coverage is 94.59459% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.03%. Comparing base (476a485) to head (a6bb228).
⚠️ Report is 5 commits behind head on main.

Files with missing lines Patch % Lines
visualizer/graph/graphSummary.py 90.00% 3 Missing ⚠️
visualizer/descriptors/faq.py 97.05% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #586      +/-   ##
==========================================
- Coverage   96.05%   96.03%   -0.02%     
==========================================
  Files         130      130              
  Lines        6087     6158      +71     
==========================================
+ Hits         5847     5914      +67     
- Misses        240      244       +4     
Files with missing lines Coverage Δ
visualizer/tests/filenames.py 100.00% <100.00%> (ø)
visualizer/tests/testFaq.py 100.00% <100.00%> (ø)
visualizer/descriptors/faq.py 99.06% <97.05%> (-0.39%) ⬇️
visualizer/graph/graphSummary.py 96.22% <90.00%> (-2.50%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 476a485...a6bb228. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@artoonie artoonie merged commit f46bda2 into main Nov 6, 2025
8 checks passed
@artoonie artoonie deleted the feature/tiebreak-faq branch November 6, 2025 19:06
@davidlbangs
Copy link

Looks good!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tie breaker support in RCVis

3 participants