Enhancement: Use Constructor injection on AppMetrics#121
Merged
denisvmedia merged 1 commit intoartprima:masterfrom Jun 17, 2025
Merged
Enhancement: Use Constructor injection on AppMetrics#121denisvmedia merged 1 commit intoartprima:masterfrom
AppMetrics#121denisvmedia merged 1 commit intoartprima:masterfrom
Conversation
Contributor
Author
|
I'm not able to run PHPCS locally:
|
mvhirsch
force-pushed
the
feature/immutable-app-metrics
branch
from
7e0b36c to
3f938ac
Compare
Contributor
Author
|
Thinking about immutable |
mvhirsch
force-pushed
the
feature/immutable-app-metrics
branch
from
3f938ac to
7f6ab17
Compare
mvhirsch
force-pushed
the
feature/immutable-app-metrics
branch
from
7f6ab17 to
1add5f1
Compare
Contributor
Author
|
Where you able to take a look @denisgcm @denisvmedia? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing ctor injection for immutability in
AppMetricsas requested by @denisvmedia in #116 (comment).