test: Add nextest config by artrixdotdev · Pull Request #79 · artrixdotdev/tortillas

artrixdotdev · 2025-08-01T06:20:38Z

Partially fixes #64

Adds a nextest config that kills hanging tests that last over 10 seconds

Summary by CodeRabbit

Chores
- Added new test configuration profiles to improve test reliability and control test behavior.
- Marked several unstable tests to be skipped by default during test runs.
- Cleaned up unused imports in test modules.

coderabbitai · 2025-08-01T06:20:46Z

Walkthrough

A new Nextest configuration file is added with custom retry and timeout profiles for test execution. Three unstable tests in the peer and engine modules are now ignored by default. An unused import is removed from the tracker HTTP module's test section. No changes affect exported or public APIs.

Changes

Cohort / File(s)	Change Summary
Nextest CI Configuration `.config/nextest.toml`	Adds Nextest config with `ci` and `default` profiles, specifying retries, fail-fast, and slow timeout settings.
Peer Module Test Annotation `crates/libtortillas/src/peers/mod.rs`	Marks `test_peer_connection` and `test_peer_to_peer_pieces` as ignored due to instability; test logic unchanged.
Engine Module Test Annotation `crates/libtortillas/src/engine/mod.rs`	Marks `test_torrent_with_magnet_uri` as ignored due to instability; test logic unchanged.
Tracker HTTP Test Import Cleanup `crates/libtortillas/src/tracker/http.rs`	Removes unused import of `Tracker` in test module, leaving only `TrackerTrait`.

Sequence Diagram(s)

Not applicable: No new features or control flow changes introduced.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Assessment against linked issues

Objective	Addressed	Explanation
Filter out inconsistent tests from CI using Nextest profiling and ignore unstable tests (#64)	✅

Assessment against linked issues: Out-of-scope changes

No out-of-scope changes found.

Possibly related PRs

feat: Added Nextest, added Nextest to workflows, and updated documentation regarding Nextest #39: Adds Nextest installation and usage to CI workflows and documentation, related to Nextest integration and configuration.

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 49b5470 and 153785e.

📒 Files selected for processing (1)

.config/nextest.toml (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

.config/nextest.toml

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: build_and_test

✨ Finishing Touches

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch test/nextest-config

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (2)

.config/nextest.toml (1)

5-8: Consider aligning retry counts or documenting the rationale

profile.default retries 4 times whereas profile.ci retries 3. If this asymmetry is intentional (e.g., you want developers to be more forgiving locally), add a short comment in the file; otherwise keep them consistent.
crates/libtortillas/src/peers/mod.rs (1)
410-414: #[ignore] tag added—consider making the reason machine-discoverable

Marking the flaky test as ignored is fine, but add context so CI dashboards show why it’s skipped and when to re-enable, e.g.:
-#[ignore] // Not stable yet
+#[ignore = "flaky: relies on external peer, see issue #64"]
Better yet, gate it behind a feature flag so it can still run in nightly or stress builds.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 894f717 and 5390a80.

📒 Files selected for processing (3)

.config/nextest.toml (1 hunks)
crates/libtortillas/src/peers/mod.rs (1 hunks)
crates/libtortillas/src/tracker/http.rs (1 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

crates/libtortillas/src/tracker/http.rs (2)

crates/libtortillas/src/tracker/mod.rs (2)

TrackerTrait (22-28)

udp (19-19)

crates/libtortillas/src/tracker/udp.rs (1)

tests (979-1033)

🔇 Additional comments (1)

crates/libtortillas/src/tracker/http.rs (1)

506-510: Import list trimmed correctly

Dropping the unused Tracker import silences a warning without affecting functionality; TrackerTrait is still needed for the blanket method calls. Nice cleanup.

.config/nextest.toml

artrixdotdev · 2025-08-01T06:36:17Z

@kurealnum Check if there's anything else that should be added to the config

https://nexte.st/docs/configuration/

kurealnum · 2025-08-01T14:04:54Z

@kurealnum Check if there's anything else that should be added to the config

https://nexte.st/docs/configuration/

I set failure-output to "immediate-final" for sake of clarity (docs). This PR should be finished. Tests no longer hang, and tests work both on local and remote (GitHub).

artrixdotdev added 2 commits July 31, 2025 22:40

test: Add nextest settings for ci

863a58a

test: Ignore unstable test

5390a80

coderabbitai bot reviewed Aug 1, 2025

View reviewed changes

.config/nextest.toml Show resolved Hide resolved

test: Add more ignores & add reasons for each ignore

49b5470

artrixdotdev requested a review from kurealnum August 1, 2025 06:34

chore: Added failure-output parameter to config

153785e

kurealnum merged commit 70cef91 into main Aug 1, 2025
3 checks passed

kurealnum deleted the test/nextest-config branch August 1, 2025 14:06

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: Add nextest config#79

test: Add nextest config#79
kurealnum merged 4 commits intomainfrom
test/nextest-config

artrixdotdev commented Aug 1, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Aug 1, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

artrixdotdev commented Aug 1, 2025

Uh oh!

kurealnum commented Aug 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

artrixdotdev commented Aug 1, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Assessment against linked issues

Assessment against linked issues: Out-of-scope changes

Possibly related PRs

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

artrixdotdev commented Aug 1, 2025

Uh oh!

kurealnum commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

artrixdotdev commented Aug 1, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Aug 1, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

kurealnum commented Aug 1, 2025 •

edited

Loading