Merged
Conversation
gkartalis
previously approved these changes
Mar 2, 2026
MrSltun
reviewed
Mar 2, 2026
src/elements/Skeleton/Skeleton.tsx
Outdated
|
|
||
| useEffect(() => { | ||
| Animated.loop( | ||
| const loop = Animated.loop( |
Member
There was a problem hiding this comment.
Question: Do we need a different variable here? Or can we use animationRef instead?
Member
Author
There was a problem hiding this comment.
good idea - i will do that
MrSltun
previously approved these changes
Mar 2, 2026
Member
MrSltun
left a comment
MrSltun
left a comment
There was a problem hiding this comment.
Looks good! 🌟
The code seems a bit confusing to read for me, but that's not a blocker
Member
Author
You can think of the API like the |
Collaborator
|
🚀 PR was released in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes some memory leaks we had on animated skeleton components. The main issue here, is that when we unmount the skeleton, the loop persists on the native side (because
useNativeDriver).