Skip to content

Remove integrations fallback using Requires #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 9, 2024
Merged

Remove integrations fallback using Requires #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c5e488f
Remove fallback on Requires
sethaxen Nov 9, 2024
398796e
Remove Random as dependency
sethaxen Nov 9, 2024
383c7bf
Increment patch number
sethaxen Nov 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,13 +1,11 @@
name = "InferenceObjects"
uuid = "b5cf5a8d-e756-4ee3-b014-01d49d192c00"
authors = ["Seth Axen <[email protected]> and contributors"]
version = "0.4.3"
version = "0.4.4"

[deps]
Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"
DimensionalData = "0703355e-b756-11e9-17c0-8b28908087d0"
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
Requires = "ae029012-a4dd-5104-9daa-d747884805df"
Tables = "bd369af6-aec1-5ad0-b16a-f7cc5008161c"

[weakdeps]
Expand All @@ -34,7 +32,6 @@ OffsetArrays = "1"
OrderedCollections = "1.6"
PosteriorStats = "0.1.1, 0.2"
Random = "1.9"
Requires = "1.1.0"
StatsBase = "0.33.7, 0.34"
Tables = "1.10.0"
julia = "1.9"
Expand Down
15 changes: 4 additions & 11 deletions ext/InferenceObjectsMCMCDiagnosticToolsExt/InferenceObjectsMCMCDiagnosticToolsExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,10 @@
module InferenceObjectsMCMCDiagnosticToolsExt

using Base: @doc
if isdefined(Base, :get_extension)
using DimensionalData: DimensionalData, Dimensions, LookupArrays
using InferenceObjects: InferenceObjects
using MCMCDiagnosticTools: MCMCDiagnosticTools
using Random: Random
else # using Requires
using ..DimensionalData: DimensionalData, Dimensions, LookupArrays
using ..InferenceObjects: InferenceObjects
using ..MCMCDiagnosticTools: MCMCDiagnosticTools
using ..Random: Random
end
using DimensionalData: DimensionalData, Dimensions, LookupArrays
using InferenceObjects: InferenceObjects
using MCMCDiagnosticTools: MCMCDiagnosticTools
using Random: Random

include("utils.jl")
include("bfmi.jl")
Expand Down
12 changes: 3 additions & 9 deletions ext/InferenceObjectsNCDatasetsExt/InferenceObjectsNCDatasetsExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,8 @@
module InferenceObjectsNCDatasetsExt

if isdefined(Base, :get_extension)
using DimensionalData: DimensionalData, Dimensions, LookupArrays
using NCDatasets: NCDatasets
using InferenceObjects
else
using ..DimensionalData: DimensionalData, Dimensions, LookupArrays
using ..NCDatasets: NCDatasets
using ..InferenceObjects
end
using DimensionalData: DimensionalData, Dimensions, LookupArrays
using NCDatasets: NCDatasets
using InferenceObjects

function InferenceObjects.from_netcdf(path::AbstractString; kwargs...)
return NCDatasets.NCDataset(path, "r"; kwargs...) do ds
Expand Down
15 changes: 4 additions & 11 deletions ext/InferenceObjectsPosteriorStatsExt/InferenceObjectsPosteriorStatsExt.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,10 @@
module InferenceObjectsPosteriorStatsExt

using Base: @doc
if isdefined(Base, :get_extension)
using DimensionalData: DimensionalData, Dimensions, LookupArrays
using InferenceObjects: InferenceObjects
using PosteriorStats: PosteriorStats
using StatsBase: StatsBase
else # using Requires
using ..DimensionalData: DimensionalData, Dimensions, LookupArrays
using ..InferenceObjects: InferenceObjects, stack
using ..PosteriorStats: PosteriorStats
using ..StatsBase: StatsBase
end
using DimensionalData: DimensionalData, Dimensions, LookupArrays
using InferenceObjects: InferenceObjects
using PosteriorStats: PosteriorStats
using StatsBase: StatsBase

include("utils.jl")
include("hdi.jl")
Expand Down
24 changes: 0 additions & 24 deletions src/InferenceObjects.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,6 @@ using Dates: Dates
using DimensionalData: DimensionalData, Dimensions, LookupArrays
using Tables: Tables

const EXTENSIONS_SUPPORTED = isdefined(Base, :get_extension)

# groups that are officially listed in the schema
const SCHEMA_GROUPS = (
:posterior,
Expand Down Expand Up @@ -45,29 +43,7 @@ include("from_namedtuple.jl")
include("from_dict.jl")
include("io.jl")

if !EXTENSIONS_SUPPORTED
using Requires: @require
end
function __init__()
@static if !EXTENSIONS_SUPPORTED
@require MCMCDiagnosticTools = "be115224-59cd-429b-ad48-344e309966f0" begin
@require Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c" begin
include(
"../ext/InferenceObjectsMCMCDiagnosticToolsExt/InferenceObjectsMCMCDiagnosticToolsExt.jl",
)
end
end
@require NCDatasets = "85f8d34a-cbdd-5861-8df4-14fed0d494ab" begin
include("../ext/InferenceObjectsNCDatasetsExt/InferenceObjectsNCDatasetsExt.jl")
end
@require PosteriorStats = "7f36be82-ad55-44ba-a5c0-b8b5480d7aa5" begin
@require StatsBase = "2913bbd2-ae8a-5f71-8c99-4fb6c76f3a91" begin
include(
"../ext/InferenceObjectsPosteriorStatsExt/InferenceObjectsPosteriorStatsExt.jl",
)
end
end
end
if isdefined(Base.Experimental, :register_error_hint)
Base.Experimental.register_error_hint(MethodError) do io, exc, argtypes, kwargs
if exc.f === from_netcdf &&
Expand Down
Loading