Draft
Conversation
Member
Author
|
Going to hold off on merging this just yet since I'll probably refine the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplifies the model comparison APIs. While the functionality being removed here may still be useful, removing these now allows us to reduce the support burden for the package, and we can add these back slowly if users request them:
model_weightsfrom API (weights can still be computed and accessed usingcompare)weights_methodkeyword forcompareto simplymethodinformation_criterion(TODO: document relationship between ELPD and information criteria)AbstractELPDResultfrom the APIelpd_estimates(in favor of user accessing theestimatesandpointwisefields ofPSISLOOResultdirectly)