[WIP] Numpyro converter refactor#128
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #128 +/- ##
===========================================
- Coverage 72.50% 50.46% -22.04%
===========================================
Files 19 19
Lines 1902 1920 +18
===========================================
- Hits 1379 969 -410
- Misses 523 951 +428 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Documentation build overview
Show files changed (9 files in total): 📝 9 modified | ➕ 0 added | ➖ 0 deleted
|
OriolAbril
left a comment
There was a problem hiding this comment.
Thanks! I am very behind on reviews (as usual) so seeing it is a draft and doesn't have a description yet I am not reviewing yet. Don't hesitate to ping me whenever you want a review on this.
Sounds good thank you, I'll let you know! I jumped the gun a little bit and thought I'd have more time to wrap this up last week. Consolidating the divergent patterns between all of the numpyro samplers has been more complicated than I thought and I might spend some more time this week comparing a SamplingWrapper approach to this in-progress abstract base class approach |
|
You can have drafts PRs open for as long as you want. I don't think opening them early will ever be an issue |
|
Hi @kylejcaron, I’m interested in contributing to the Numpyro converter refactor. |
|
Closing in favor of #142 |
No description provided.