Skip to content

[WIP] Numpyro converter refactor#128

Closed
kylejcaron wants to merge 4 commits intoarviz-devs:mainfrom
kylejcaron:numpyro_converter_refactor
Closed

[WIP] Numpyro converter refactor#128
kylejcaron wants to merge 4 commits intoarviz-devs:mainfrom
kylejcaron:numpyro_converter_refactor

Conversation

@kylejcaron
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2026

Codecov Report

❌ Patch coverage is 26.12613% with 82 lines in your changes missing coverage. Please review.
✅ Project coverage is 50.46%. Comparing base (2d5b97c) to head (4dd70bb).

Files with missing lines Patch % Lines
src/arviz_base/io_numpyro.py 26.12% 82 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (2d5b97c) and HEAD (4dd70bb). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (2d5b97c) HEAD (4dd70bb)
5 3
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #128       +/-   ##
===========================================
- Coverage   72.50%   50.46%   -22.04%     
===========================================
  Files          19       19               
  Lines        1902     1920       +18     
===========================================
- Hits         1379      969      -410     
- Misses        523      951      +428     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@read-the-docs-community
Copy link

read-the-docs-community bot commented Jan 12, 2026

Documentation build overview

📚 arviz-base | 🛠️ Build #31009101 | 📁 Comparing 4dd70bb against latest (2d5b97c)


🔍 Preview build

Show files changed (9 files in total): 📝 9 modified | ➕ 0 added | ➖ 0 deleted
File Status
_modules/arviz_base/io_numpyro.html 📝 modified
api/generated/arviz_base.dataset_to_dataarray.html 📝 modified
api/generated/arviz_base.dataset_to_dataframe.html 📝 modified
api/generated/arviz_base.dict_to_dataset.html 📝 modified
api/generated/arviz_base.explode_dataset_dims.html 📝 modified
api/generated/arviz_base.extract.html 📝 modified
api/generated/arviz_base.from_numpyro.html 📝 modified
api/generated/arviz_base.references_to_dataset.html 📝 modified
api/generated/arviz_base.xarray_sel_iter.html 📝 modified

@kylejcaron kylejcaron changed the title Numpyro converter refactor [WIP] Numpyro converter refactor Jan 14, 2026
Copy link
Member

@OriolAbril OriolAbril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I am very behind on reviews (as usual) so seeing it is a draft and doesn't have a description yet I am not reviewing yet. Don't hesitate to ping me whenever you want a review on this.

@kylejcaron
Copy link
Contributor Author

Thanks! I am very behind on reviews (as usual) so seeing it is a draft and doesn't have a description yet I am not reviewing yet. Don't hesitate to ping me whenever you want a review on this.

Sounds good thank you, I'll let you know! I jumped the gun a little bit and thought I'd have more time to wrap this up last week. Consolidating the divergent patterns between all of the numpyro samplers has been more complicated than I thought and I might spend some more time this week comparing a SamplingWrapper approach to this in-progress abstract base class approach

@OriolAbril
Copy link
Member

You can have drafts PRs open for as long as you want. I don't think opening them early will ever be an issue

@patelshivani2283-lab
Copy link

Hi @kylejcaron, I’m interested in contributing to the Numpyro converter refactor.
Would you like me to help with tests or additional improvements?

@kylejcaron kylejcaron closed this Feb 6, 2026
@kylejcaron kylejcaron reopened this Feb 6, 2026
@kylejcaron
Copy link
Contributor Author

Closing in favor of #142

@kylejcaron kylejcaron closed this Feb 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants