docs: add CmdStanPy getting-started example#143
docs: add CmdStanPy getting-started example#143patelshivani2283-lab wants to merge 16 commits intoarviz-devs:mainfrom
Conversation
|
Hi! |
OriolAbril
left a comment
There was a problem hiding this comment.
Link to the CmdStanPy conversion guide for further details
This page doesn't exist and should be added so it shows on the sidebar. If you look at the preview you can see the sidebar has not been updated because the page you are trying to add to it doesn't exist.
From the discussion on the issue, I'd say the fact cmdstanpy didn't have a dedicated page but the other PPLs did was the main problem so I would focus on that instead of adding an example on the landing page (which will probably need some updates but they need more discussion before we decide/agree what those changes should be).
|
Added the CmdStanPy conversion notebook as discussed. |
|
Hi @patelshivani2283-lab, you have not added any changes since the review, maybe you forgot to push? |
|
All changes here are documentation-only. |
|
Hi, I have applied the requested changes:
Please let me know if anything else is needed from my side. Thank you! |
| :caption: Tutorials | ||
| :hidden: | ||
|
|
||
| tutorial/WorkingWithDataTree |
|
Hi Sir, Moved the CmdStanPy example to its dedicated guide Updated the sidebar/tutorial ordering alphabetically Fixed formatting issues and unintended changes Updated WorkingWithDataTree notebook as needed Please let me know if anything else is needed. Thank you! |
|
please double-check docs/source/index.md |
|
Hi @OriolAbril, I also see that the external tests are failing — please let me know if this is related to my changes or if anything else is needed from my side. Thank you! |
OriolAbril
left a comment
There was a problem hiding this comment.
I have gone over the previous comments and marked most of them as "resolved". I strongly recommend you do this yourself to keep track of what has been addressed and what hasn't. You removed the workingwithdatatree page from the sidebar which is a huge blocker for merging the PR and was pointed out by @aloctavodia already yet it is still deleted.
This is general advise, not specific to this round of review, but it could have helped with the issue I mention above. It is also a good idea to review your own PR from the "Files changed" tab. There you can see
WorkingWithDataTree is removed and not added anywhere else. It should continue to be listed and it should continue to be the first element on the sidebar (my previous comment about ordering was about order of the 3 conversion guides, not about the sidebar as a whole, the label guide doesn't really matter but the datatree page should be the first).
You can also click on the ... and "View details" on the CI checks to take a look at the failure reasons, here is one example. If you look at that you can see that CI is indeed failing for reasons directly related to your changes. I think you will be able to fix this with tox -e check directly, but also note we have recently updated a few contributing pages so it might also be helpful to check the PR checklist and similar pages like the PR step-by-step page.
OriolAbril
left a comment
There was a problem hiding this comment.
It looks like you did not run nor check the linting and formatting rules. Please read my last comment again
|
Hi @OriolAbril, |

This PR addresses feedback from the JOSS review regarding discoverability
of CmdStanPy support.
Changes:
This should make it clearer to new users how to use ArviZ with CmdStanPy
without needing to search the API reference.