Set histogram density=True by default#307
Open
aatifjunaid wants to merge 2 commits intoarviz-devs:mainfrom
Open
Set histogram density=True by default#307aatifjunaid wants to merge 2 commits intoarviz-devs:mainfrom
aatifjunaid wants to merge 2 commits intoarviz-devs:mainfrom
Conversation
Contributor
|
There are other instances where we have density=None and should have density=True |
Author
|
I’ve addressed the requested changes. Please let me know if anything else needs adjustment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR sets density=True as the default value for histogram.
Updated default argument in histogram.
Verified consistency across base and numba backends.
All existing tests pass.
Let me know if additional tests are preferred to explicitly check default behavior.