feat:ASTx to pythonAST transpiler implementation with fixes from Identifier Issues#287
Merged
xmnlab merged 4 commits intoarxlang:mainfrom Aug 29, 2025
nagajaideep:main
Merged
feat:ASTx to pythonAST transpiler implementation with fixes from Identifier Issues#287xmnlab merged 4 commits intoarxlang:mainfrom nagajaideep:main
xmnlab merged 4 commits intoarxlang:mainfrom
nagajaideep:main
Conversation
xmnlab
approved these changes
Aug 29, 2025
Contributor
xmnlab
left a comment
There was a problem hiding this comment.
thanks @nagajaideep , lgtm! appreciate it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request description
This PR implements mentor-aligned refactoring of the ASTx transpiler architecture to separate AST conversion from string generation, resolving circular dependencies and improving maintainability.
Changes Made:
python_to_ast.pyby removingpython_stringimport.python_string.py(new file) to handle ASTx → Python source code generation viaast.unparse().This aligns with the mentor’s requested architecture:
How to test these changes
Run the new test file:
python -m pytest libs/astx-transpilers/tests/test_python_to_ast.py libs/astx-transpilers/tests/test_python_string.py -v; pre-commit run --all-filesOr manually:
Expected: Correct AST objects and Python source code strings are produced.
Pull Request checklists
Note:
proposed in this PR, in both image and ASCII formats. For more
information, check this Google Colab notebook:
https://colab.research.google.com/drive/1xXwHmOMkJKFSmhRvn4WYfSAsdDzMnawf?usp=sharing
This PR is a:
About this PR:
Author's checklist:
Additional information
Benefits of this refactoring:
python_to_ast.py)ast.unparse()for consistent string generationReviewer's checklist