Added possibility to turn off adjusting button heights by indicator height #19
Conversation
…eight - used for high indicators as in implemented example
|
Thanks for the PR, this could be a good addition, but It feels weird that So the flag is set to op, but it doesn't behave as the name would suggest (adjust button height)
|
ScrollPager/Source/ScrollPager.swift
Outdated
| addSubview(indicatorView) | ||
| } | ||
| } | ||
| insertSubview(indicatorView, belowSubview: buttons.first!) |
There was a problem hiding this comment.
let's just insert into index 0 that way we don't force unwrap
|
Also please update the code to use tabs instead of spaces to be constant with the rest of the code |
|
Hi, it's still using indicator heights because you can have for example 4pt indicator height, but want the labels to be in the middle of the view instead of shifted a bit top. And setting indicator height to equal with control height we have tabs effect. I'll fix insertSubview and spaces 👍 |
|
aaah, makes sense |
2 participants
Used for high indicators as in implemented example -
thirdScrollPager. Also changed order of subviews so that indicator is behind buttons.