-
Notifications
You must be signed in to change notification settings - Fork 15
Added run_request_campaign function to handle Request Campaign API in… #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
pythonmarketo/client.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python syntax guide please use spaces after "," when specifying parameters
pythonmarketo/client.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
camp_dict where is it used?
pythonmarketo/client.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add space after args,
pythonmarketo/client.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have any test for this method so that I can run it before merging the pulled changes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here you go...
-
Sandip
On Tuesday, May 19, 2015 10:19 AM, Arunim Samat [email protected] wrote:
In pythonmarketo/client.py:> @@ -236,7 +237,29 @@ def create_lead(self, lookupField, lookupValue, values):
] } return self.post(data)- Do you have any test for this method so that I can run it before merging the pulled changes?—
Reply to this email directly or view it on GitHub.
- Do you have any test for this method so that I can run it before merging the pulled changes?—
…ng a filter. 2. Merge leads
…ng a filter. 2. Merge leads
Conflicts: pythonmarketo/client.py
Created an extra method to handle one more API from Marketo. Will return true if success and false otherwise.