-
Notifications
You must be signed in to change notification settings - Fork 77
Add AngouriMath.Terminal to NuGet publishing workflow and use ProjectReference for internal dependencies #647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Co-authored-by: Happypig375 <[email protected]>
Co-authored-by: Happypig375 <[email protected]>
|
@copilot Are there other hardcoded versions that should be removed? |
Yes, there are hardcoded dependency versions in PackageReference tags that are outdated:
These are different from the However, since the NuGet workflow builds packages in dependency order and uses ProjectReference during the build, these hardcoded versions don't affect the workflow. They would only matter if someone tried to build the packages independently from NuGet. Should I update these PackageReference versions to match Package.Build.props (1.4.0-preview.4)? |
|
@copilot Update them to directly use the version in Package.Build.props and add a comment there that it won't affect CI builds. |
….props Co-authored-by: Happypig375 <[email protected]>
Updated in commit 0de4b60. Changed:
Added comment: "Using $(Version) from Package.Build.props. This won't affect CI builds as they use ProjectReference." Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
|
@copilot Actually, just replace it with a project reference - it seems easier to manage anyway. |
Co-authored-by: Happypig375 <[email protected]>
Done in commit c2489cc. Replaced PackageReference with ProjectReference:
All internal dependencies now consistently use ProjectReference, which is simpler to manage. |
The NuGet workflow publishes AngouriMath, AngouriMath.FSharp, and AngouriMath.Interactive but not AngouriMath.Terminal, which uses a separate TerminalNightly workflow for binary releases only.
Changes
.github/workflows/Nuget.yml: Added publishing step for AngouriMath.Terminal following the pattern of other packages. Publishes to MyGet on master pushes and NuGet.org on releases.Sources/Terminal/AngouriMath.Terminal/AngouriMath.Terminal.fsproj: Removed hardcoded<Version>1.4.0-preview.3-2</Version>to align with other packages. Now inherits version from Package.Build.props or workflow override via-p:PackageVersion.Sources/Wrappers/AngouriMath.FSharp/AngouriMath.FSharp.fsproj: Replaced PackageReference with ProjectReference to AngouriMath. Changed from<PackageReference Include="AngouriMath" Version="1.4.0-preview.3" />to<ProjectReference Include="..\..\AngouriMath\AngouriMath.csproj" />.Sources/Wrappers/AngouriMath.Interactive/AngouriMath.Interactive.fsproj: Replaced PackageReference with ProjectReference to AngouriMath.FSharp. Changed from<PackageReference Include="AngouriMath.FSharp" Version="1.4.0-preview.3" />to<ProjectReference Include="..\AngouriMath.FSharp\AngouriMath.FSharp.fsproj" />.Notes
The TerminalNightly workflow continues to produce standalone binaries for the AngouriMathLab repository independently.
All internal dependencies now consistently use ProjectReference, which simplifies dependency management and ensures that local changes are always used during builds. This follows the same pattern already used by AngouriMath.Terminal.
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.