Skip to content

fix: remove prettier-plugin-svelte to fix CI#827

Merged
ascorbic merged 1 commit intomainfrom
fix-prettier-svelte
Dec 8, 2025
Merged

fix: remove prettier-plugin-svelte to fix CI#827
ascorbic merged 1 commit intomainfrom
fix-prettier-svelte

Conversation

@ascorbic
Copy link
Owner

@ascorbic ascorbic commented Dec 8, 2025

Summary

Remove prettier-plugin-svelte from packages/svelte to fix CI format action failures.

The plugin was causing CI failures because:

  1. The format workflow uses pull_request_target which checks out main
  2. When prettier runs from root, it picks up packages/svelte/.prettierrc which requires the plugin
  3. The plugin can't be resolved in the CI environment

The root format command (**/*.{ts,tsx,js,jsx,json,md,astro}) doesn't format .svelte files anyway, so the plugin isn't needed.

Changes

  • Remove prettier-plugin-svelte from packages/svelte/package.json
  • Remove packages/svelte/.prettierrc

Test plan

  • pnpm format works locally

🤖 Generated with Claude Code

The plugin was causing CI failures because it couldn't be resolved
when running prettier from the root. The root format command doesn't
format .svelte files anyway.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <[email protected]>
@changeset-bot
Copy link

changeset-bot bot commented Dec 8, 2025

⚠️ No Changeset found

Latest commit: a0653f3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Dec 8, 2025

Deploy Preview for unpic-next failed. Why did it fail? →

Name Link
🔨 Latest commit a0653f3
🔍 Latest deploy log https://app.netlify.com/projects/unpic-next/deploys/6936bb16646d17000837011c

@netlify
Copy link

netlify bot commented Dec 8, 2025

Deploy Preview for unpic-docs ready!

Name Link
🔨 Latest commit a0653f3
🔍 Latest deploy log https://app.netlify.com/projects/unpic-docs/deploys/6936bb1649acb8000874ab22
😎 Deploy Preview https://deploy-preview-827.preview.unpic.pics
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@netlify
Copy link

netlify bot commented Dec 8, 2025

Deploy Preview for unpic-angular failed. Why did it fail? →

Name Link
🔨 Latest commit a0653f3
🔍 Latest deploy log https://app.netlify.com/projects/unpic-angular/deploys/6936bb162a15b60008b93118

@ascorbic ascorbic merged commit aa1b273 into main Dec 8, 2025
15 of 25 checks passed
@ascorbic ascorbic deleted the fix-prettier-svelte branch December 8, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant