Skip to content

Replace custom sort with sort -V#16

Open
J3RN wants to merge 1 commit intoasdf-community:masterfrom
J3RN:fix-sorting
Open

Replace custom sort with sort -V#16
J3RN wants to merge 1 commit intoasdf-community:masterfrom
J3RN:fix-sorting

Conversation

@J3RN
Copy link

@J3RN J3RN commented Apr 23, 2024

The current sorting is sorting the new version (10.0.0) incorrectly:

$ mise ls-remote chezscheme
10.0.0
9.4
9.5
9.5.1
9.5.2
9.5.4
9.5.6
9.5.8
9.5.8a
9.6.0
9.6.2
9.6.4

Sorting can be fixed by replacing the custom sort implementation with the sort command's "version sort" capability:
Screenshot from 2024-04-23 00-19-00

@J3RN J3RN requested a review from a team as a code owner April 23, 2024 04:25
@fapdash
Copy link

fapdash commented Jan 16, 2025

Currently the plugin is trying to install v9.6.0 as the latest version although v10.1.0 is out, would be great if this change could be merged. :)

@smorimoto
Copy link
Member

@cubic-dev-ai review this

@cubic-dev-ai
Copy link

cubic-dev-ai bot commented Mar 4, 2026

@cubic-dev-ai review this

@smorimoto I have started the AI code review. It will take a few minutes to complete.

Copy link

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants