Conversation
This was referenced Aug 26, 2025
4183f46 to
e47f2b0
Compare
6 tasks
7472bbe to
c7de359
Compare
ad4be18 to
5f292c7
Compare
Contributor
Author
|
From offline discussion @zacharyburnett suggested |
Contributor
Author
|
During the dev->unstable rename I noticed a lack of CI job here testing the unstable schemas. I updated this PR to add a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update core schemas:
This is the start of 1.7.0 core schemas which triggers:
The goal of the new structure is to allow package testing (to see what updates are required to support the new core schemas) without making it too easy for a user to write files using the development schemas. We want to make writing files with these development schemas difficult because there is no expectation that the development schemas will be stable (put another way, the development schemas may change without a version change).
To accomplish this this PR:
ASDF_UNSTABLE_CORE_SCHEMASto flag registration of the new development schemas_versioningmodule which can be used by asdf to get which stable and dev versions of the core schemas are in this version of the asdf-standard module.exceptionssubmodule with a new warning typeUnstabeCoreSchemasWarningwhich will be issued whenASDF_UNSTABLE_CORE_SCHEMASis set and the dev schemas are returned as "supported".asdf-format/asdf#1962 extends this PR allowing asdf to use the
ASDF_UNSTABLE_CORE_SCHEMASto:The above process makes it difficult for a user to write out a file using the unstable schemas (they must define the environment variable). I'm also considering options for creating warnings when writing files with the dev version (although this may prove more harmful than helpful and get in the way of many unit tests).
If we adopt the above approach, at some point in the future we'll want to release the "unstable" schemas by:
_versioningThis will trigger asdf to start using the now new "stable" version as the default.