-
Notifications
You must be signed in to change notification settings - Fork 30
Add missing transform schemas #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing transform schemas #485
Conversation
0903693 to
23e0d01
Compare
| stsci.edu/asdf/wcs/frame-1.0.0.yaml | ||
| stsci.edu/asdf/wcs/frame-1.1.0.yaml | ||
| stsci.edu/asdf/wcs/spectral_frame-1.1.0.yaml | ||
| stsci.edu/asdf/wcs/step-1.1.0.yaml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few remaining skips for schemas that aren't referenced by any core schemas. However the changes in this PR allow removal of more than half the skips.
| asdf_schema_tests_enabled = 'true' | ||
| asdf_schema_ignore_unrecognized_tag = 'true' | ||
| addopts = '--color=yes' | ||
| addopts = '--color=yes -r a' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This just prints out extra information about skipped, failed or errored tests.
|
Would it be useful to add comments in both the "legacy" schema to be explicit that these are only for legacy cases and should not be used in future cases? |
Thanks. How about adding these to the "legacy" schemas in the docs? EDIT: added to legacy docs in 1fb9552 |
|
That seems reasonable to be consistent with the others. |
perrygreenfield
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Closes #484
Add copies of transform-1.0.0 and domain-1.0.0 to the schemas. These are referenced by the core schema asdf-1.0.0 but were previously moved to asdf-transform-schemas. This resulted in a need to add asdf-transform-schemas to a dependency of asdf (but left this package incomplete).
See asdf-format/asdf#1965 for a test showing that this fixes failures that would otherwise be seen if asdf drop asdf-transform-schemas as a dependency.