Skip to content

Conversation

@braingram
Copy link
Contributor

@braingram braingram commented Aug 27, 2025

Closes #484

Add copies of transform-1.0.0 and domain-1.0.0 to the schemas. These are referenced by the core schema asdf-1.0.0 but were previously moved to asdf-transform-schemas. This resulted in a need to add asdf-transform-schemas to a dependency of asdf (but left this package incomplete).

See asdf-format/asdf#1965 for a test showing that this fixes failures that would otherwise be seen if asdf drop asdf-transform-schemas as a dependency.

@braingram braingram force-pushed the missing_transform_schemas branch from 0903693 to 23e0d01 Compare August 27, 2025 19:45
stsci.edu/asdf/wcs/frame-1.0.0.yaml
stsci.edu/asdf/wcs/frame-1.1.0.yaml
stsci.edu/asdf/wcs/spectral_frame-1.1.0.yaml
stsci.edu/asdf/wcs/step-1.1.0.yaml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few remaining skips for schemas that aren't referenced by any core schemas. However the changes in this PR allow removal of more than half the skips.

asdf_schema_tests_enabled = 'true'
asdf_schema_ignore_unrecognized_tag = 'true'
addopts = '--color=yes'
addopts = '--color=yes -r a'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just prints out extra information about skipped, failed or errored tests.

@braingram braingram marked this pull request as ready for review August 27, 2025 19:49
@perrygreenfield
Copy link

Would it be useful to add comments in both the "legacy" schema to be explicit that these are only for legacy cases and should not be used in future cases?

@braingram
Copy link
Contributor Author

braingram commented Aug 27, 2025

Would it be useful to add comments in both the "legacy" schema to be explicit that these are only for legacy cases and should not be used in future cases?

Thanks. How about adding these to the "legacy" schemas in the docs?

EDIT: added to legacy docs in 1fb9552

@perrygreenfield
Copy link

That seems reasonable to be consistent with the others.

Copy link

@perrygreenfield perrygreenfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@braingram braingram merged commit 1e2ac68 into asdf-format:main Aug 27, 2025
25 of 26 checks passed
@braingram braingram deleted the missing_transform_schemas branch October 16, 2025 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add missing transform schemas.

2 participants