Skip to content

fix: remove dead code and fix undefined variable in test_plugin.bash #1138

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hyperpolymath wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: remove dead code and fix undefined variable in test_plugin.bash #1138

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions scripts/test_plugin.bash
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,6 @@ function fail() {
exit 1
}

# Extract the link to a svg badge from a line of README.
function badge_svg() {
grep -o '(http[^)]*svg[^)]*)' | sed -e 's/(//;s/)//'
}

function check_plugins_from_diff() {
local BASE_REF="$1" # Base commit of main branch.
local HEAD_REF="$2" # Latest commit of PR
Expand All @@ -24,7 +19,7 @@ function check_plugins_from_diff() {
test 1 -lt "$(echo "$DIFF_CHANGES" | wc --lines | xargs)" &&
echo "$DIFF_CHANGES" | grep README.md >/dev/null &&
echo "$DIFF_CHANGES" | grep plugins/ >/dev/null
} || fail "Expected git diff ${REF_RANGE} to only include changes for a single plugin"
} || fail "Expected git diff ${BASE_REF}..${HEAD_REF} to only include changes for a single plugin"

local PLUGIN_FILES
PLUGIN_FILES="$(git diff --name-only "${BASE_REF}" "${HEAD_REF}" -- plugins/)"
Expand Down Expand Up @@ -111,7 +106,7 @@ else
Test that a plugin at PLUGIN_FILE follows basic sanity checks:
* A plugins/<plugin> file contains the repository url.
* A new line is added on README.md with a link mentioning the plugin.
* The new plugin has CI badge and it's passing.
* The plugin repository is reachable via git.

Usage:

Expand Down