feat: print requested version on fail , closes #2033#2034
feat: print requested version on fail , closes #2033#2034hfi-wiit wants to merge 1 commit intoasdf-vm:masterfrom
Conversation
hfi-wiit
changed the title
|
Unsure what we need to do to get this merged. It's a very simple fix and the change is appreciated. I hate the current message |
|
|
||
| if len(existingPluginToolVersions) == 0 { | ||
| return "", plugins.Plugin{}, "", false, NoVersionSetError{shim: shimName} | ||
| return "", plugins.Plugin{}, requestedVersion, false, NoVersionSetError{shim: shimName} |
There was a problem hiding this comment.
I think this should only return a version as the 3 value if a matching one is found. Is there a reason this return value was changed?
There was a problem hiding this comment.
Thanks for the PR @hfi-wiit ! Sorry for the late review, I'm only now catching up on PRs. The changes appear good, but we need tests before we merge to ensure this works as expected in all cases and so to prevent future regressions. I'll circle back to this in about a week and write tests then. In the meantime you are welcome to contribute tests if you want.
|
Also I think we may want to address #1467 in this as well. |
3 participants
As requested in #2033, this PR just adds a few lines to print the requested version in the event the related binary version is not installed.