fix: nushell completions --ignore-errors deprecation #2157
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait, I've just realized the fix might need to be a little more complicated. It looks like nushell introduced the new flag and deprecated the old one in the same release. Merging this PR would break completions for anyone on earlier versions. I'm not sure how you want to handle that? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update nushell completion code to use the new flag.
Edit: Warning! Will break completions entirely for anyone on earlier versions that 0.106.0. Maybe don't merge this.
Fixes: #2156
Other Information
Thanks for the great tool, I've been using it to earn a living for years.