feat: add <git-ref> positional argument support to asdf plugin add#2167
Open
elijahr wants to merge 7 commits intoasdf-vm:masterfrom
Open
feat: add <git-ref> positional argument support to asdf plugin add#2167elijahr wants to merge 7 commits intoasdf-vm:masterfrom
<git-ref> positional argument support to asdf plugin add#2167elijahr wants to merge 7 commits intoasdf-vm:masterfrom
Conversation
- Fixes the `--asdf-plugin-gitref` argument so it works as expected. - Adds an optional <git-ref> argument to `asdf plugin add`, i.e. `asdf plugin add <plugin-name> [<git-ref>]`
elijahr
changed the title
--asdf-plugin-gitref, add <git-ref> arg to asdf plugin add<git-ref> positional argument support to asdf plugin add
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--asdf-plugin-gitrefargument so it works as expected.asdf plugin add, i.e.asdf plugin add <plugin-name> [<git-url>] [<git-ref>]giturl#gitrefas requested in Support plugin install giturl#gitref #1201, as it seemed simpler;#would require quoting the URL in some shells, and theasdf plugin update <plugin-name> [<git-ref>]pattern is already established.Fixes: #1201, #2131