fix: update nushell completion code so it works on latest version of nushell - #2275
Conversation
Stratus3D
changed the title
Stratus3D
changed the title
There was a problem hiding this comment.
Pull request overview
This PR updates Nushell completion support by adjusting the shipped Nushell completion module export and updating the getting-started documentation snippet for loading Nushell completions.
Changes:
- Export the
asdfNushell module contents from the completion file viaexport use asdf *. - Update Nushell docs to use
sourcewhen loading the generatednushell.nucompletions file.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/completions/asdf.nushell | Re-exports the asdf module’s exported commands for Nushell completion consumers. |
| docs/guide/getting-started.md | Updates Nushell setup instructions to use source for loading the completions file. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| ) | ||
| . "$asdf_data_dir/completions/nushell.nu" | ||
| source "$asdf_data_dir/completions/nushell.nu" | ||
| ``` |
There was a problem hiding this comment.
@kuchta can you update the other references copilot found?
|
You're welcome @Stratus3D. The docs should now be updated for the other two languages |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Stratus3D
changed the title
Summary
Fixes: Completions and docs for nushell
Other Information